Skip to content

gNMI-1.28:Changes to support Juniper Devices#5595

Open
priyaranjannanda wants to merge 6 commits into
openconfig:mainfrom
priyaranjannanda:gNMI-1.28_1
Open

gNMI-1.28:Changes to support Juniper Devices#5595
priyaranjannanda wants to merge 6 commits into
openconfig:mainfrom
priyaranjannanda:gNMI-1.28_1

Conversation

@priyaranjannanda

Copy link
Copy Markdown
Contributor
  • Changes to add deviation state_path_unsupported for Juniper Platform
  • Changes to testTelemetryInterfacesStateSubinterface for subinterfaceindex to 0 for Juniper.

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner June 18, 2026 11:38
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the gNMI telemetry interface test suite to provide better compatibility with Juniper platforms. By introducing platform-specific deviations and adjusting test parameters for subinterface indexing, the changes ensure that the automated tests correctly handle Juniper's device requirements without impacting other platforms.

Highlights

  • Juniper Platform Support: Added a new platform exception for Juniper devices to include the state_path_unsupported deviation in the metadata configuration.
  • Test Logic Adjustments: Updated the telemetry interface test to set the subinterface index to 0 for Juniper devices and modified the cleanup logic to target specific configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Jun 18, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces platform-specific logic for Juniper devices in telemetry_interfaces_test.go to set the subinterface index to 0 and delete only the subinterface description configuration. It also adds a platform exception block for Juniper in metadata.textproto. The review feedback correctly points out that hardcoding vendor-specific checks violates the repository's Deviation Guidelines. The reviewer recommends defining a new deviation, SubinterfaceZeroOnly, using it in the test code, and enabling it in the metadata file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread feature/gnmi/tests/telemetry_interfaces_test/metadata.textproto
priyaranjannanda and others added 5 commits June 18, 2026 17:18
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants