gNMI-1.28:Changes to support Juniper Devices#5595
Conversation
priyaranjannanda
commented
Jun 18, 2026
- Changes to add deviation state_path_unsupported for Juniper Platform
- Changes to testTelemetryInterfacesStateSubinterface for subinterfaceindex to 0 for Juniper.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the gNMI telemetry interface test suite to provide better compatibility with Juniper platforms. By introducing platform-specific deviations and adjusting test parameters for subinterface indexing, the changes ensure that the automated tests correctly handle Juniper's device requirements without impacting other platforms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5595 / 28656c7Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request introduces platform-specific logic for Juniper devices in telemetry_interfaces_test.go to set the subinterface index to 0 and delete only the subinterface description configuration. It also adds a platform exception block for Juniper in metadata.textproto. The review feedback correctly points out that hardcoding vendor-specific checks violates the repository's Deviation Guidelines. The reviewer recommends defining a new deviation, SubinterfaceZeroOnly, using it in the test code, and enabling it in the metadata file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>