Fix fragment-offset-range pattern escaping in single-quoted strings#1460
Fix fragment-offset-range pattern escaping in single-quoted strings#1460charanjith-anet wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the fragment-offset-range regex pattern in openconfig-packet-match-types.yang by replacing double backslashes with single backslashes for the range separator. The reviewer suggests adding regression tests to a separate test file to validate the pattern against various valid and invalid inputs.
The pattern and posix-pattern for fragment-offset-range use '\\.' (double backslash) in single-quoted YANG strings. Since single-quoted strings have no escape processing (RFC 7950 Section 6.1.3), '\\.' stores as literal backslash-backslash-dot, which in regex means "literal backslash followed by any character" — not the intended "literal dot". All other patterns in the OpenConfig models correctly use '\.' (single backslash) for literal dot matching in single-quoted strings (e.g. area-address in openconfig-isis-types.yang).
charanjith-anet
force-pushed
the
fix-fragment-offset-pattern
branch
from
4194a37 to
4c53a6b
Compare
charanjith-anet
requested review from
aashaikh,
dplore and
robshakir
as code owners
|
/gcbrun |
|
No major YANG version changes in commit 9fa6b76 |
|
/gcbrun |
|
Reviewed at the OC Operators Meeting on May 5th, 2026: If the tests are passing, they seem to verify this is working as intended after the change. Seems to match the formatting used in, e.g. this pattern. We'll move to last-call in 2 weeks assuming the tests pass. (May 19th, 2026) |
ElodinLaarz
left a comment
ElodinLaarz
left a comment
There was a problem hiding this comment.
Need to update OC version since we're editing the file.
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
need to update version number, but otherwise LGTM.
Reviewed in May 12, 2026 OC Operators meeting without objection.
|
I corrected the version number. LGTM |
|
/gcbrun |
|
/gcbrun |
|
@charanjith-anet the yang file seems to have a syntax error: |
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
Need to fix this:
Error: [release/models/acl/openconfig-packet-match-types.yang:418:0: missing 1 closing brace]
|
OC review June 2nd. Moving it back to Waiting for Author. |
5 participants
Fix typo in fragment-offset-range pattern: '\.' should be '.'
In single-quoted YANG strings, there is no escape processing (RFC 7950 §6.1.3). So '\.' is stored as two backslashes followed by a dot, which in regex matches "backslash then any char" — not "literal dot".
Every other OC pattern that needs a literal dot uses '.' correctly,
e.g. area-address in openconfig-isis-types.yang:
pattern '[a-fA-F0-9]{2}(.[a-fA-F0-9]{4}){3,9}.[a-fA-F0-9]{2}';
Change Scope
\\.→\.in both pattern and posix-pattern for fragment-offset-rangePlatform Implementations
Pattern-only fix, no model/tree changes.
Tree View
N/A