Skip to content

Add leaves for common org-defined TLVs to LLDP neighbor state #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeshg-arista wants to merge 10 commits into
base: master
Choose a base branch
from
+74 −1
Open

Add leaves for common org-defined TLVs to LLDP neighbor state #1478

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1f2a84f
Add leaves for common org defined TLVs to LLDP model
yogeshg-arista Apr 14, 2026
2053cff
Add leaves for common org defined TLVs to LLDP model
yogeshg-arista Apr 14, 2026
db884d6
Merge branch 'master' of github.com:yogeshg-arista/public
yogeshg-arista Apr 15, 2026
1e33506
Merge branch 'openconfig:master' into master
yogeshg-arista Apr 22, 2026
2a4764a
Address review: use uint16 for port-vlan-id, split link-aggregation i…
yogeshg-arista Apr 22, 2026
ebc906f
Remove extra newline.
yogeshg-arista Apr 22, 2026
390598a
Merge branch 'master' into master
dplore May 5, 2026
cdbef70
Merge branch 'master' into master
yogeshg-arista May 7, 2026
69ac85c
Wrap link-aggregation leaves in container, fix whitespace
yogeshg-arista May 7, 2026
046af94
Address comments in PR 1478
yogeshg-arista Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 74 additions & 1 deletion release/models/lldp/openconfig-lldp.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,15 @@ module openconfig-lldp {
"This module defines configuration and operational state data
for the LLDP protocol.";

oc-ext:openconfig-version "1.1.0";
oc-ext:openconfig-version "1.2.0";

revision "2026-04-14" {
description
"Add LLDP neighbor state leaves for LLDP-MED inventory serial
number, IEEE 802.1 port VLAN ID, and IEEE 802.3 link aggregation
and max frame size.";
reference "1.2.0";
}

revision "2026-04-06" {
description
Expand Down Expand Up @@ -386,6 +394,71 @@ module openconfig-lldp {
typing to pair up with the 802.1AB Management Address TLV
specification.";
}

leaf med-inventory-serial-number {
type string;
description
"The serial number of the remote device as advertised in
the LLDP-MED Inventory - Serial Number TLV.";
reference
"ANSI/TIA-1057, Sec 10.2.6.4 - Inventory - Serial Number
TLV (OUI 00-12-BB, subtype 8)";
}

leaf port-vlan-id {
type uint16 {

@earies earies Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we're at the point where there should be a proper reusable typedef for this - the closest current one sits in openconfig-vlan-types but restricts to 1..4094 - maybe something directly in openconfig-types or adjustment within that model is warranted

@yogeshg-arista yogeshg-arista Jun 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @earies. We see two options here:

Option 1: New typedef (e.g. vlan-id-or-none) in openconfig-vlan-types

A new typedef with range 0..4094 that explicitly documents the semantics of 0 (the system either does not know the PVID or does not support Port-based VLAN operation). This keeps the existing vlan-id (range 1..4094) untouched, so no risk to current consumers. The downside is introducing a second VLAN ID typedef that is very similar to the existing one.

Option 2: Widen existing vlan-id typedef from 1..4094 to 0..4094

One typedef covers both cases. But this changes the contract for all existing users of vlan-id across OpenConfig models. Config leaves that use this typedef would suddenly accept 0, which may not be meaningful in those contexts, and implementations might mishandle the value 0.

Given the risks of Option 2, we lean toward Option 1 but would appreciate the community's input. Also open to keeping the inline uint16 { range "0..4094"; } as-is if a new typedef isn't warranted for a single use.

@dplore @earies @rgwilton and the community, please let us know your thoughts on this.

range "0..4094";
}
description
"The port VLAN identifier advertised by the
neighbor in the IEEE 802.1 Port VLAN ID TLV. A value of 0
indicates that the port is not VLAN-aware.";
reference
"Annex D of IEEE Std 802.1Q - Port VLAN ID TLV
(OUI 00-80-C2, subtype 1)";
}

leaf link-aggregation-capable {
type boolean;
description
"Indicates whether the neighbor port is capable of being
aggregated, as advertised in the IEEE 802.3 Link Aggregation
TLV.";
reference
"Sec 79.3.3 of IEEE Std 802.3 - Link Aggregation TLV
(OUI 00-12-0F, subtype 3)";
}

leaf link-aggregation-enabled {
type boolean;
description
"Indicates whether the neighbor port is currently aggregated,
as advertised in the IEEE 802.3 Link Aggregation TLV.";
reference
"Sec 79.3.3 of IEEE Std 802.3 - Link Aggregation TLV
(OUI 00-12-0F, subtype 3)";
}

leaf link-aggregation-port-id {
type uint32;
description
"The aggregated port identifier of the neighbor port as
advertised in the IEEE 802.3 Link Aggregation TLV.";
reference
"Sec 79.3.3 of IEEE Std 802.3 - Link Aggregation TLV
(OUI 00-12-0F, subtype 3)";
}

leaf max-frame-size {
type uint16;
description
"The maximum frame size in octets supported by the
neighbor port as advertised in the IEEE 802.3 Maximum
Frame Size TLV.";
reference
"Sec 79.3.4 of IEEE Std 802.3 - Maximum Frame Size TLV
(OUI 00-12-0F, subtype 4)";
}
}

grouping lldp-capabilities-config {
Expand Down