Clarify trigger semantics for pipeline-errors 'threshold' and 'active'#1494
Open
earies wants to merge 1 commit into
Open
Clarify trigger semantics for pipeline-errors 'threshold' and 'active'#1494earies wants to merge 1 commit into
earies wants to merge 1 commit into
Conversation
* (M) release/models/platform/openconfig-platform-pipeline-counters.yang
- Clarify trigger semantics for 'threshold' and 'active'
- Increment to version 0.5.2
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-platform-pipeline-counters YANG model to version 0.5.2. It adds a new revision entry and provides clearer descriptions for the threshold and active leaves regarding their trigger and transition semantics. A review comment correctly identifies that the revision date is set to a future date and should be corrected.
Member
|
/gcbrun |
|
No major YANG version changes in commit 9987b23 |
|
OC Review June 2nd. There is an conflicting change that has bumped up the version of the yang file to 6.0, please make the version change into 6.1 after re basing to latest master for us to take it further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Scope
Clarify the trigger semantics shared by pipeline-errors-common
thresholdandactiveleafs. Documentation only change, no schema changes.Platform Implementations
N/A
Tree View
No tree updates were made as part of this patchset.