Skip to content

Add hierarchical-fec bool leaf to static nexthop-group #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romeyod wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add hierarchical-fec bool leaf to static nexthop-group #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion release/models/network-instance/openconfig-network-instance-static.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ module openconfig-network-instance-static {
description
"Static configurations associated with a network instance";

oc-ext:openconfig-version "0.2.1";
oc-ext:openconfig-version "0.3.0";

revision "2026-05-20" {
description
"Add hierarchical-fec leaf to static next-hop-group.";
reference "0.3.0";
}

revision "2025-08-05" {
description
Expand Down Expand Up @@ -149,6 +155,18 @@ module openconfig-network-instance-static {
description
"A user defined name that uniquely identifies the next-hop-group.";
}

leaf hierarchical-fec {
type boolean;

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is recommended to provide a default value for boolean leaves in OpenConfig to ensure deterministic behavior when the leaf is not explicitly configured. Based on the description, false (representing flattened behavior) appears to be the appropriate default for backward compatibility.

      type boolean;
      default false;

description
"When set to true, the next-hop-group preserves its hierarchical
structure, with each next-hop entry explicitly pointing to the
resolving next-hop-group. This enables load-balancing of traffic
forwarded through each next-hop-group entry based on the
bandwidth of the resolving links. When set to false, the
next-hop-group contents are flattened, or a single next-hop is
selected from each referenced group.";
Comment on lines +161 to +168

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The description for hierarchical-fec refers to next-hop entries "explicitly pointing to the resolving next-hop-group" and mentions a "referenced group". However, the current static next-hop configuration (defined in static-nhg-next-hop and oc-loc-rt:local-static-nexthop-config) does not provide a mechanism for a next-hop to reference another next-hop-group.

To enable the hierarchical behavior described, a leaf (e.g., next-hop-group as a leafref) should be added to the next-hop configuration. Additionally, there is a discrepancy between the PR description ("single random next-hop") and the leaf description ("single next-hop... from each referenced group").

}
}

grouping static-nhg-next-hop {
Expand Down
Loading