openconfig keychain send-and-receive description update.#1499
openconfig keychain send-and-receive description update.#1499ishwarbnaik wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-keychain YANG model to version 0.6.0, adding a new revision and clarifying the behavior of the send-and-receive leaf in its description. The reviewer identified inconsistent indentation in the updated description and recommended adding a must statement to programmatically enforce the constraint that a distinct receive-lifetime should not be configured when send-and-receive is true.
| description | ||
| "When this is set to true (the default value), the specified send-lifetime | ||
| is also used in the receive direction; configuration of a distinct | ||
| receive-lifetime is not valid in that case and the server should reject it | ||
| as an invalid configuration. When set to false, the device uses the | ||
| configured receive-lifetime for the receive direction (asymmetric mode). | ||
| If send-and-receive is false and the device does not support asymmetric | ||
| configuration, the server should reject the config as unsupported."; |
There was a problem hiding this comment.
The indentation of the description text is inconsistent; lines 118-123 have an extra leading space compared to line 117.
Additionally, while the updated description clarifies that configuring a distinct receive-lifetime is invalid when send-and-receive is true, this constraint should be enforced programmatically using a must statement. This ensures that the server correctly rejects invalid configurations as stated in the description and the PR objectives.
description
"When this is set to true (the default value), the specified send-lifetime
is also used in the receive direction; configuration of a distinct
receive-lifetime is not valid in that case and the server should reject it
as an invalid configuration. When set to false, the device uses the
configured receive-lifetime for the receive direction (asymmetric mode).
If send-and-receive is false and the device does not support asymmetric
configuration, the server should reject the config as unsupported.";
must "not(.) or not(../../../receive-lifetime/config/start-time or ../../../receive-lifetime/config/end-time)" {
error-message "Distinct receive-lifetime cannot be configured when send-and-receive is true";
}
|
/gcbrun |
|
No major YANG version changes in commit e1b5c83 |
Change Scope
Related Issues
Fixes #1476
Platform Implementations
NA
Tree View
No changes to tree view