Sync from kubeflow/model-registry 6eb25cf#7394
Sync from kubeflow/model-registry 6eb25cf#7394openshift-merge-bot[bot] merged 22 commits intoopendatahub-io:mainfrom
Conversation
…ails (opendatahub-io#2627) Upstream commit: 65332e0ae2b74e4431224cc31afe7638a80c7e1b
…e cat is available (opendatahub-io#2599) (resolved conflicts) Upstream commit: c6ee0da7fb0d9f70287c8ae6f0b7db532f2b2663
…r jobs (opendatahub-io#2625) Upstream commit: 244666c3f300b8297018220daca4d7750f2abaa4
…06ff000af5a114d0aca6 (no file changes)
…2353ea3bcafb316afc8e (no file changes)
…5008cadefcf9109edf14 (no file changes)
…d93954c1f30d4556edcc (no file changes)
…5ba77b58a421e1649f22 (no file changes)
…cbbad717c0c8c5ea6204 (no file changes)
…029d6d834eb8f3e8d8c0 (no file changes)
…b955bac05ab676a18202 (no file changes)
…pendatahub-io#2639) Upstream commit: 243b2e06d73d685f24468a38aa3017e09c9de217
…atahub-io#2635) (resolved conflicts) Upstream commit: 21e661b1a78d475b7d3614ea015c8ff763d5216d
…c7b33d2082666ced6ca1 (no file changes)
…0bc530ba6d1902bfd149 (no file changes)
…20778da75f383a0c1311 (no file changes)
…0a5f456b7602abcb39ac (no file changes)
…nks (opendatahub-io#2640) Upstream commit: 37f93891df2636c0da76db9b265b95c950938851
…25e6eb07ccdf86da2f77 (no file changes)
…headers in webpack dev proxy (opendatahub-io#2544) Upstream commit: 653ff5102b46a8c7f85f0d389aae3318fe696a94
…rom 8.5.6 to 8.5.10 in /clients/ui/frontend (opendatahub-io#2641) Upstream commit: 6eb25cfb3ce76cd0f87438ea7de60b414dd6e25a
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (146)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7394 +/- ##
==========================================
- Coverage 65.10% 65.06% -0.05%
==========================================
Files 2466 2466
Lines 76565 76604 +39
Branches 19338 19358 +20
==========================================
- Hits 49848 49841 -7
- Misses 26717 26763 +46
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
da47dfa
into
opendatahub-io:main
Description
Sync to pull in changes from:
Conflicts Resolved
The following conflicts were resolved during this sync:
#2599 - hide cat toggle in case only one cat is available
frontend/src/app/pages/modelCatalog/screens/ModelCatalog.tsxNature of conflict: The downstream file has additional imports and logic not present upstream — extension point integration (
LazyCodeRefComponent,useExtensions,isModelCatalogBannerExtension) and search param handling for the?validated=trueURL parameter. The upstream patch expected a simpler file without these additions.Resolution: Merged both sets of changes: kept the downstream extension point banner rendering and validated search param logic, while incorporating all upstream additions (single-category detection, empty state handling,
isSingleCategory/singleCategoryLabelprops, and thehasNoCategoriesempty state).#2635 - chore: rename go modules
bff/go.modNature of conflict: The downstream
go.modhad a slightly different Go version (1.25.0) than what upstream expected (1.25.7), causing context mismatch for the module rename patch.Resolution: Applied the module rename from
github.com/kubeflow/model-registry/ui/bfftogithub.com/kubeflow/hub/ui/bffwhile keeping the downstream dependency versions intact.Additional Downstream Fix
The Go module rename in #2635 only updated upstream files via the sync script. Downstream-only Go files in
internal/redhat/,internal/helpers/, andcmd/still referenced the old module pathgithub.com/kubeflow/model-registry/ui/bff. Updated all 19 downstream files to use the newgithub.com/kubeflow/hub/ui/bffmodule path.How Has This Been Tested?
Tested by running the federated model-registry package locally, verifying existing behavior in the files this diff touches, and verifying the incoming changes.
Also ran available test scripts in
packages/model-registry/upstream/frontend:npm run test:unit— 57 suites, 697 tests passednpm run test:type-check— clean, no errorsnpm run test:lint— 0 warnings, 0 errorsgo vet ./...— clean after downstream import fixTest Impact
Upstream changes include their own tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
mainSummary by CodeRabbit