Skip to content

Emit notice when compiling with -release - #124

Merged
adamdruppe merged 7 commits into
opendlang:masterfrom
analogjupiter:ludicrous-release
Aug 31, 2026
Merged

Emit notice when compiling with -release#124
adamdruppe merged 7 commits into
opendlang:masterfrom
analogjupiter:ludicrous-release

Conversation

@0xEAB

@0xEAB 0xEAB commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Partially revamps ldc-developers/ldc#4739 — but for DMD.

Warning: Compiling with `-release` can have undesirable side effects and is discouraged.
	Please consult the documentation for details.
	For fast binaries through strong optimization, use LDC, the LLVM-based D Compiler, instead.

Using -ludicrous instead of -release gets one rid of the notice message.

@adamdruppe

Copy link
Copy Markdown
Contributor

sooooooo druntime uses it in the build. i guess kidna harmless but maybe it should be updated

@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

I know it’s tiring, but please review these substitutions. I’ve staged them patch by patch but it is easy to miss a case where -release shouldn’t have been substituted.

@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

3ddd480 is untested.

@adamdruppe

Copy link
Copy Markdown
Contributor

actually i might have made a mistake in requesting that cuz it bootstrap builds w/ upstream....... ugh

@adamdruppe

Copy link
Copy Markdown
Contributor

so yeah sorry for making you do something tedious and useless but it should prolly just keep using -release for compatibility with upstream host compilers doing the build, the message is ok to see anyway tbh

@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

do something tedious

No big deal, running find -exec sed {} ain’t that much work.
Just the patch staging is a tad monotonous (hence the increased chance of making a mistake).

@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

cuz it bootstrap builds w/ upstream....... ugh

But doesn’t it use the fresh DMD to build druntime + Phobos?
DMD=/upstream-dmd/generated/linux/release/64/dmd make dmd druntime phobos works for me.

@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

oh, ENABLE_RELEASE=1 make dmd is broken, but that’s due to my patch for build.d being insufficient nonsense.

@0xEAB
0xEAB force-pushed the ludicrous-release branch from 3ddd480 to 818adf6 Compare August 31, 2026 01:52
@0xEAB

0xEAB commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

I think this should work fine now.

@adamdruppe

Copy link
Copy Markdown
Contributor

well let's try it and see lol

@adamdruppe
adamdruppe merged commit c6f6366 into opendlang:master Aug 31, 2026
3 checks passed
@adamdruppe

Copy link
Copy Markdown
Contributor

yea it failed so ima undo the changes to the build scripts

@adamdruppe

Copy link
Copy Markdown
Contributor

actually it isn't the build script, it is the ldc commit saying redefinition. megannoying template magic

@adamdruppe

Copy link
Copy Markdown
Contributor

or actually maybe just a reused variable lemme try changing that

@0xEAB

0xEAB commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

awesome, thanks ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants