lib/blobstore: fix real clones check#71
Merged
tiagolobocastro merged 2 commits intov25.05.x-mayastorfrom Apr 16, 2026
Merged
Conversation
niladrih
approved these changes
Apr 15, 2026
The presence of the clone source uuid is not sufficient to check if a blob is clone of a snapshot, as it may be a clone of another snapshot. So now we check if the source uuid matches the snapshot itself. We also iterate the entire snapshot chain for clones, and not just the immediate ones. Change-Id: Ida00901debb60abad6801449688ddf6411fb1308 Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-snap-clone
branch
from
f90ea79 to
0396dbf
Compare
Iterates the blob tree itself, and inspects the blob xattr to find out if the blob is a clone of our source snapshot. This avoids iterating the snapshot list multiple times, which is what destroyes the performance of the previous commit. If we could modify the snapshot tree to be rb as well, we could probably revert back to the previous commit's approach. Change-Id: Ie542091b92a02365a7022f621550e52adfb8cbea Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-snap-clone
branch
from
88ae326 to
b73c929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the clone source uuid is not sufficient to check if a blob is clone of a snapshot, as it may be a clone of another snapshot.
So now we check if the source uuid matches the snapshot itself.