consider default page size if its zero during lvs grow#72
Merged
Abhinandan-Purkait merged 1 commit intov25.05.x-mayastorfrom Apr 21, 2026
Merged
consider default page size if its zero during lvs grow#72Abhinandan-Purkait merged 1 commit intov25.05.x-mayastorfrom
Abhinandan-Purkait merged 1 commit intov25.05.x-mayastorfrom
Conversation
abhilashshetty04
changed the title
abhilashshetty04
force-pushed
the
lvs_grow_fix
branch
from
1a276b0 to
1658126
Compare
There was a problem hiding this comment.
Pull request overview
Updates the blobstore live-grow path to handle legacy super blocks where the metadata page size wasn’t persisted, preventing invalid calculations during an LVS (lvol store) grow.
Changes:
- Default
ctx->super->md_page_sizetoSPDK_BS_PAGE_SIZEwhen it is read as0inspdk_bs_grow_live()’s super-block load completion path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tiagolobocastro
approved these changes
Apr 20, 2026
abhilashshetty04
force-pushed
the
lvs_grow_fix
branch
from
1658126 to
4c25e16
Compare
Abhinandan-Purkait
approved these changes
Apr 21, 2026
abhilashshetty04
force-pushed
the
lvs_grow_fix
branch
from
4c25e16 to
5a21b13
Compare
If the metadata page size is not set, then it means that the blobstore was created with an older version of SPDK. In that case, we can assume that the page size is equal to SPDK_BS_PAGE_SIZE, since that's what it was in older versions Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
abhilashshetty04
force-pushed
the
lvs_grow_fix
branch
from
5a21b13 to
75be891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the metadata page size is not set, then it means that the blobstore was created with an older version of SPDK. In that case, we can assume that the page size is equal to SPDK_BS_PAGE_SIZE, since that's what it was in older versions