Added vendor specific subsystem pause/resume#74
Open
susobhandey wants to merge 3 commits intoopenebs:v24.01.x-mayastorfrom
Open
Added vendor specific subsystem pause/resume#74susobhandey wants to merge 3 commits intoopenebs:v24.01.x-mayastorfrom
susobhandey wants to merge 3 commits intoopenebs:v24.01.x-mayastorfrom
Conversation
if vendor sets flag during subsystem pause we keep allowing keep alive for 120 sec even though subsystem is not active There is no change in fabric command. Only we allow admin cmds for 120 sec Signed-off-by: Susobhan Dey <susobhan.dey@datacore.com>
added 2 commits
May 7, 2026 20:07
scripts/rpc.py nvmf_subsystem_set_pause_timeout <nqn> <time in sec> Signed-off-by: Susobhan Dey <susobhan.dey@datacore.com>
Signed-off-by: Susobhan Dey <susobhan.dey@datacore.com>
Member
|
This is against the wrong base branch @susobhandey, should be |
Member
tiagolobocastro
left a comment
tiagolobocastro
left a comment
There was a problem hiding this comment.
Please change the base branch of the commit
| struct spdk_nvmf_subsystem_poll_group *sgroup = NULL; | ||
| struct spdk_nvmf_subsystem_pg_ns_info *ns_info; | ||
| uint32_t nsid; | ||
| struct spdk_nvmf_subsystem *subsystem = NULL; |
Member
There was a problem hiding this comment.
You can leave it unset as well, since it's init before being used (also seems to be the practice in spdk AFAIK)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if vendor sets flag during subsystem pause
we keep allowing keep alive for 120 sec even though subsystem is not active There is no change in fabric command. Only we allow admin cmds for 120 sec