Skip to content

feat: Socket automatic retry as the same of that of python-sdk #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abishek-Newar wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Socket automatic retry as the same of that of python-sdk #307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd176c5
feat: Socket automatic retry as the same of that of python-sdk
Abishek-Newar Jan 23, 2026
3182389
Merge branch 'main' into socker-hang-up
SoulPancake Feb 16, 2026
70ae607
changes acc to comments
Abishek-Newar Feb 23, 2026
caeffd2
Merge branch 'main' into socker-hang-up
Abishek-Newar Feb 23, 2026
d6b4926
Merge branch 'main' into socker-hang-up
Abishek-Newar Mar 15, 2026
cc00f2b
Merge branch 'main' into socker-hang-up
Abishek-Newar Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@ export const createRequestFunction = function (axiosArgs: RequestArgs, axiosInst
configuration.isValid();

const retryParams = axiosArgs.options?.retryParams ? axiosArgs.options?.retryParams : configuration.retryParams;
const maxRetry: number = retryParams?.maxRetry ?? 0;
const minWaitInMs: number = retryParams?.minWaitInMs ?? 0;
const maxRetry: number = retryParams?.maxRetry ?? SdkConstants.DefaultMaxRetry;
const minWaitInMs: number = retryParams?.minWaitInMs ?? SdkConstants.DefaultMinWaitInMs;

const start = performance.now();
Comment thread
Abishek-Newar marked this conversation as resolved.

Expand Down
2 changes: 1 addition & 1 deletion tests/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,7 @@ describe("OpenFGA Client", () => {
user: "user:81684243-9356-4421-8fbf-a4f8d36aa31b",
object: "workspace:1",
relations: ["admin", "guest", "reader", "viewer"],
});
Comment thread
Abishek-Newar marked this conversation as resolved.
}, { retryParams: { maxRetry: 0 } });
} catch (err) {
expect(scope0.isDone()).toBe(true);
expect(scope1.isDone()).toBe(true);
Expand Down
Loading