[broadlinkthermostat] Aesthetic rename and add RM Mini - #13412
Merged
Conversation
wborn
added
enhancement
Member
Author
|
CI error seems to be unrelated. |
lolodomo
added
rebuild
Contributor
I have no definitive opinion on the two possible options. @openhab/add-ons-maintainers : WDYT ? |
Member
|
I think "broadlink" would be a better name, too. We discussed this partially in #11049. But I don't see much benefit of renaming this now and breaking all installations. I'd suggest to rename it with the OH 4 release (whenever that will be) and add the new device in the existing binding. |
Member
Author
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
broadlink/migrate_binding
branch
from
October 7, 2022 15:41
b83c04f to
10b9a3a
Compare
GiviMAD
changed the title
Member
Author
lolodomo
requested changes
Oct 15, 2022
Contributor
|
As mentioned in one of my review comments, you introduced a breaking change (by renaming a thing type) and I think it can be avoided, in a simple way. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Contributor
|
There is now no more breaking changes that I can identify, that is a good point. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [broadlinkthermostat] Aesthetic rename and add RM Mini Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [broadlinkthermostat] Aesthetic rename and add RM Mini Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/broadlink-binding-for-rmx-a1-spx-and-mp-any-interest/22768/1527 |
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* [broadlinkthermostat] Aesthetic rename and add RM Mini Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [broadlinkthermostat] Aesthetic rename and add RM Mini Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [broadlinkthermostat] Aesthetic rename and add RM Mini Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Álvarez miguelwork92@gmail.com
This is a proposal for renaming the broadlinkthermostat binding into broadlink also add a new device type "RM Mini" which is a universal controller infrared device.
Instead of adding a new binding I thought it was better to rename the current one, as the package relies in a library which supports other devices, as indicated in the readme.
Let me know in case is better to create a new binding.
To keep the autor aware @flo-02-mu.