Skip to content

2320: No method to remove the 'clean' label#1762

Open
edvbld wants to merge 1 commit intoopenjdk:masterfrom
edvbld:skara-2320
Open

2320: No method to remove the 'clean' label#1762
edvbld wants to merge 1 commit intoopenjdk:masterfrom
edvbld:skara-2320

Conversation

@edvbld
Copy link
Copy Markdown
Member

@edvbld edvbld commented Mar 25, 2026

Hi all,

please review this patch that adds the set and remove arguments to the /clear pull request command.

Thanks,
Erik



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • SKARA-2320: No method to remove the 'clean' label (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1762/head:pull/1762
$ git checkout pull/1762

Update a local copy of the PR:
$ git checkout pull/1762
$ git pull https://git.openjdk.org/skara.git pull/1762/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1762

View PR using the GUI difftool:
$ git pr show -t 1762

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1762.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 25, 2026

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 25, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 25, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 25, 2026

Webrevs

Copy link
Copy Markdown
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test.

@edvbld
Copy link
Copy Markdown
Member Author

edvbld commented Apr 9, 2026

@erikj79 yeah I see that, will have to look into the failures.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 9, 2026
@edvbld
Copy link
Copy Markdown
Member Author

edvbld commented Apr 9, 2026

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 9, 2026

@edvbld The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants