Skip to content

v1.1.0#36

Open
zetneteork wants to merge 22 commits into
openkilt:masterfrom
opentreecz:openrepo-upstream-pull-request
Open

v1.1.0#36
zetneteork wants to merge 22 commits into
openkilt:masterfrom
opentreecz:openrepo-upstream-pull-request

Conversation

@zetneteork

Copy link
Copy Markdown

What's Changed
1 by @zetneteork in opentreecz#1
Patch 1 by @zetneteork in opentreecz#2
Create a workflow to build the image and push it to Docker Hub by @zetneteork in opentreecz#3
Enhanced Django unit tests by @zetneteork in opentreecz#4
Added github auto docker build workflow by @zetneteork in opentreecz#5
Add comprehensive tests, auto-linting, and code coverage docs by @zetneteork in opentreecz#6
Add new test files for base repo, keyring, management commands, and e… by @zetneteork in opentreecz#7
New Contributors
@zetneteork made their first contribution in opentreecz#1
Full Changelog: opentreecz/openrepo@v1.0.0...v1.1.0

inistor and others added 22 commits July 26, 2024 10:45
…ff django container

Setting up health checks for postgres db to be ready before kicking off django container
Removed version tag - redundant as per docker.
Create a workflow to build the image and push it to Docker Hub
Added github auto docker build workflow
- Auto-format all Python files with black (line length 120) and isort
- Fix all flake8 warnings: unused imports, bare excepts, unused vars,
  f-strings without placeholders, block comment style
- Add .flake8 config with per-file E501 exceptions for shell command strings
- Add .coveragerc for reproducible coverage measurement
- Add 66 new unit tests across 6 new test files:
    test_filemanager.py, test_util.py, test_file_adapters.py,
    test_serializers.py, test_authentication.py, test_views_extended.py
- Total test suite: 84 tests, all passing, 85% overall coverage
- Add CODE_COVERAGE.md with per-module breakdown, gap analysis, and
  instructions for running coverage and CI integration
- Add repo/tests/__init__.py so Django test discovery works correctly
Add comprehensive tests, auto-linting, and code coverage docs
Bootstrap, jQuery, and Popper were referenced as local static files
that were never present in the repo. Switch to pinned CDN URLs with
SRI hashes so the login page renders correctly without requiring
collectstatic or bundled vendor files.
Add new test files for base repo, keyring, management commands, and e…
- Replace broken DockerHub-based main.yml with a proper CI test workflow
- docker-build.yml: switch trigger branch master→main, bump build-push-action v5→v6, fix latest tag condition
Worker was starting before Django finished running migrations,
causing ProgrammingError on repo_repository table. Add a healthcheck
to the django service using `migrate --check` and make worker wait
for service_healthy before starting.
refresh_count increment was a non-atomic read-modify-write, causing
two workers racing on the same repo to both compute the same
build_number and hit the unique constraint. Replace with a single
atomic UPDATE using F() expression, then re-fetch the assigned value.
Without build: . all services used the published ghcr.io image,
so local code fixes had no effect at runtime.
Add build: . to all app services so local code fixes are used
instead of the published registry image. The image: tag is kept
so the built image is still tagged as ghcr.io/opentreecz/openrepo:latest.
@zetneteork

Copy link
Copy Markdown
Author

@matthill Hello, I can see you've now published 2-week-old commits. This makes it very difficult to merge proposed updates from the fork, especially with the fixes and updates I made and opened a PR for.
In the forked repository, there are a couple of issues that fix the OpenRepo bug that was discovered.
As you can see, there are some updates, including GitHub Actions workflows for lint checks and code checks, Dependabot, release creation, and pushing to GHCR.
I am proposing a brief sync-up to discuss further cooperation.
Thanks

@matthill

matthill commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Yes, I believe we solved similar problems in parallel. My changes were committed before this PR. But I think your actual code changes were around the same time or maybe earlier? Sorry about that, I was not aware of the parallel effort. Are there features or bug fixes that are unique that we should merge? I don't want to merge this consolidated PR since I think there's a fair amount of duplicate config/code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants