ARR: Migrate Registration Forms to Root Domain#2785
ARR: Migrate Registration Forms to Root Domain#2785haroldrubio wants to merge 24 commits intomasterfrom
Conversation
| # Create Reviewing_Resubmissions edges from root domain load notes | ||
| for role_id in [area_chairs_id]: | ||
| resubmissions_to_post = [] | ||
| role_resubmissions_inv = f"{role_id}/-/Reviewing_Resubmissions" |
There was a problem hiding this comment.
This is because there is a field in the maximum load note that allows them to indicate if they're willing to review a submission they previously reviewed - reviewers who select 0 load can select 'Yes' so they only get assigned resubmissions. The SACs/ACs don't have access to the maximum load note so that information is shared in the edges. Also, they can opt out of resubmissions so the SACs/ACs need to know this information
| # Create Reviewing_Resubmissions edges from root domain load notes | ||
| for role_id in [reviewers_id]: | ||
| resubmissions_to_post = [] | ||
| role_resubmissions_inv = f"{role_id}/-/Reviewing_Resubmissions" |
There was a problem hiding this comment.
I thought we were going to store the registration notes in the root group, not edges, why do you need this?
There was a problem hiding this comment.
The refactor removes the nesting inside the for loop - hopefully it's more clear that these are edges to the cycle and not the root group
|
|
||
| return invitation | ||
|
|
||
| def set_registration_invitation(self, registration_stage): |
There was a problem hiding this comment.
the registration invitations should be the same for a regular venues or root venue, I would like to try reusing the code for both cases.
It seems that function needs: venue_id, registration_stage. Can we support this and call the same function from both?
Another option is to add a new state to the Venue class that says (support_root_venue), if this is true the regisration notes are created on the root venue instead the current venue.
There was a problem hiding this comment.
I was looking into changes for the Venue class and I'm running into a few issues:
The root venue doesn't have a venue request form (as I have implemented it right now) and doesn't get deployed, so there isn't a Venue object for the root venue. If there's a line that calls to the Venue object, I'd need to replace it.
Maybe it's worth it to deploy a full root venue instead of manually creating the meta invitation and only populating what we need, so I can better re-use code?
| recruitmentInvitationId: domain.content.reviewers_recruitment_id?.value, | ||
| reviewLoad: '', | ||
| hasPaperRanking: false, | ||
| registrationFormDomainMap: { |
There was a problem hiding this comment.
I'm not sure about this change, can we pass the list of registration invitations to the consoles as a parameter?
2 participants
This PR changes the super invitation of the registration invitations for ARR to a new root at
aclweb.org/ACL/ARRin order to (1) prevent automatic posting of data with a tilde ID signatures and (2) prevent duplication of note content (copying between cycle, copying between roles)I need to decide on how to handle some forms that should be bound to the cycle (requests for letters of recognition) - initially I was planning pointing all registration forms from the openreview-web end to point to a new domain but some should still point to the current cycle
TODOs: