Skip to content

test adding fields to Submission Change Before Reviewing #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
celestemartinez wants to merge 9 commits into
base: master
Choose a base branch
from
+104 −6
Draft

test adding fields to Submission Change Before Reviewing #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe44c95
test adding fields to Submission Change Before Reviewing
celestemartinez Feb 18, 2026
4ca4bc9
Merge branch 'master' into chore/test-delete-true
celestemartinez Feb 25, 2026
93f7ed1
fix test
celestemartinez Feb 25, 2026
cc2ccf3
run tests using fix delete branch
celestemartinez Feb 25, 2026
2dd5cdc
fix test
celestemartinez Feb 26, 2026
3e4df63
Merge branch 'master' into chore/test-delete-true
celestemartinez Feb 27, 2026
1b10931
Merge branch 'master' into chore/test-delete-true
celestemartinez Feb 27, 2026
4572ed9
Merge branch 'master' into chore/test-delete-true
celestemartinez Mar 19, 2026
8b2a41e
Merge branch 'master' into chore/test-delete-true
celestemartinez Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ parameters:
default: "master"
openreview-api-v2-branch:
type: string
default: "main"
default: "fix/delete-true"
python-version:
type: string
default: "3.13.1"
Expand Down
108 changes: 103 additions & 5 deletions tests/test_reviewers_only.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,7 +1522,103 @@ def test_reviewers_deployment(self, openreview_client, helpers):
helpers.await_queue_edit(openreview_client, edit_id=edit['id'])

def test_review_stage(self, openreview_client, helpers):


invitation = openreview_client.get_invitation('ABCD.cc/2025/Conference/-/Submission_Change_Before_Reviewing')
assert invitation.edit['note']['content'] == {
'authors': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'authorids': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'pdf': {
'readers': {
'param': {
'const': {
'delete': True
}
}
}
}
}

# edit submission change before reviewing content to hide subject_area
openreview_client.post_invitation_edit(
invitations='ABCD.cc/2025/Conference/-/Submission_Change_Before_Reviewing/Restrict_Field_Visibility',
content = {
'content_readers': {
'value': {
'authors': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'authorids': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'subject_areas': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'pdf': {
'readers': {
'param': {
'const': {
'param': {
'const': { 'delete': True },
},
},
},
}
}
}
}
}
)

invitation = openreview_client.get_invitation('ABCD.cc/2025/Conference/-/Submission_Change_Before_Reviewing')
assert invitation.edit['note']['content'] == {
'authors': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'authorids': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'subject_areas': {
'readers': [
'ABCD.cc/2025/Conference',
'ABCD.cc/2025/Conference/Submission${{4/id}/number}/Authors'
]
},
'pdf': {
'readers': {
'param': {
'const': {
'delete': True
}
}
}
}
}

now = datetime.datetime.now()
# manually trigger Submission_Chage_Before_Reviewing
openreview_client.post_invitation_edit(
Expand All @@ -1542,6 +1638,8 @@ def test_review_stage(self, openreview_client, helpers):
assert submissions[0].content['authorids']['readers'] == ['ABCD.cc/2025/Conference', 'ABCD.cc/2025/Conference/Submission1/Authors']
assert not 'readers' in submissions[0].content['pdf']
assert submissions[0].content['data_release']['readers'] == ['ABCD.cc/2025/Conference', 'ABCD.cc/2025/Conference/Submission1/Authors']
assert submissions[0].content['subject_areas']['readers'] == ['ABCD.cc/2025/Conference', 'ABCD.cc/2025/Conference/Submission1/Authors']


pc_client = openreview.api.OpenReviewClient(username='programchair@abcd.cc', password=helpers.strong_password)
assert pc_client.get_invitation('ABCD.cc/2025/Conference/-/Official_Review')
Expand Down Expand Up @@ -2563,12 +2661,12 @@ def test_reviewer_stats_computation(self, openreview_client, helpers):
assert pc_client.get_invitation('ABCD.cc/2025/Conference/Program_Committee/-/Review_Days_Late_Sum')
assert pc_client.get_invitation('ABCD.cc/2025/Conference/Program_Committee/-/Review_Days_Late_Sum/Dates')

# Remove reviewer from reviewers group
openreview_client.remove_members_from_group('ABCD.cc/2025/Conference/Program_Committee', ['~ReviewerThree_ABCD1'])

now = datetime.datetime.now()
new_cdate = openreview.tools.datetime_millis(now)

## Remove reviewer from reviewers group
openreview_client.remove_members_from_group('ABCD.cc/2025/Conference/Program_Committee', ['~ReviewerThree_ABCD1'])

## Review Count stage
pc_client.post_invitation_edit(
invitations='ABCD.cc/2025/Conference/Program_Committee/-/Review_Count/Dates',
Expand Down Expand Up @@ -2627,4 +2725,4 @@ def test_reviewer_stats_computation(self, openreview_client, helpers):
helpers.await_queue_edit(openreview_client, edit_id='ABCD.cc/2025/Conference/-/Program_Committee-0-1', count=2)

tags = openreview_client.get_tags(invitation='ABCD.cc/2025/Conference/-/Program_Committee')
assert len(tags) == 2
assert len(tags) == 2