fix: Bid Console instructions: Display conflict/affinity score text if#2944
Open
JiwaniZakir wants to merge 3 commits intoopenreview:masterfrom
Open
fix: Bid Console instructions: Display conflict/affinity score text if#2944JiwaniZakir wants to merge 3 commits intoopenreview:masterfrom
JiwaniZakir wants to merge 3 commits intoopenreview:masterfrom
Conversation
…nsole instructions (openreview#2324) Remove misleading static instruction text about conflicts and affinity scores from the bid console since these features are optional and may not be configured.
Show the conflict-of-interest bullet only when conflictInvitationId is configured, and the affinity score bullet only when affinityScoreId is configured, instead of removing them unconditionally.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Bid Console webfield configuration to conditionally include instruction tips related to conflicts and affinity scores, aiming to avoid showing irrelevant guidance when those features aren’t configured/available.
Changes:
- Extracts
conflictInvitationIdinto a top-level variable alongsideaffinityScoreId. - Updates the instructions markdown template to conditionally render the conflict and affinity-score tips.
- Updates the
conflictInvitationIdproperty assignment to reference the extracted variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
14
to
+15
| const affinityScoreId = domain.content[`${internalRole}_affinity_score_id`]?.value | ||
| const conflictInvitationId = domain.content[`${internalRole}_conflict_id`]?.value |
|
|
||
| - Papers for which you have a conflict of interest are not shown. | ||
| - Positive bids ("High" and "Very High") will, in most cases, increase the likelihood that you will be assigned that paper. | ||
| ${conflictInvitationId ? '- Papers for which you have a conflict of interest are not shown.\n' : ''}- Positive bids ("High" and "Very High") will, in most cases, increase the likelihood that you will be assigned that paper. |
| submissionVenueId: domain.content.submission_venue_id?.value, | ||
| scoreIds: affinityScoreId ? [affinityScoreId] : [], | ||
| conflictInvitationId: domain.content[`${internalRole}_conflict_id`]?.value, | ||
| conflictInvitationId: conflictInvitationId, |
Author
|
Good catch, will fix that to use shorthand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2324
The Bid Console instructions in
paperBidWebfield.jsunconditionally displayed the conflict-of-interest tip and omitted the affinity score tip for venues that had neither configured, showing irrelevant text to reviewers. The root cause was thatconflictInvitationIdwas inlined in the properties object without being available for use in the instructions template, and neither bullet used conditional rendering.Extracts
conflictInvitationIdinto a top-level variable alongsideaffinityScoreId, then gates the conflict bullet onconflictInvitationIdand restores the existing conditional for the affinity score bullet in theinstructionstemplate string. TheconflictInvitationIdproperty assignment is updated to reference the extracted variable.Verified by reviewing rendered output for venues with and without conflict/affinity score invitations configured.