Skip to content

Feat/ Journal: add option to allow only active profiles#2968

Open
celestemartinez wants to merge 13 commits intomasterfrom
feat/tmlr-force-active-profiles
Open

Feat/ Journal: add option to allow only active profiles#2968
celestemartinez wants to merge 13 commits intomasterfrom
feat/tmlr-force-active-profiles

Conversation

@celestemartinez
Copy link
Copy Markdown
Member

@celestemartinez celestemartinez commented Mar 24, 2026

This PR adds an option to the journal to force active profiles.

It also tests both these:
-profile[] with minValidState: 'Active' rejects Blocked, Limited, Rejected profiles; allows Active
-profile[] with minValidState: 'Inactive' rejects Blocked; allows Limited, Active, Rejected profiles

Depends on https://github.com/openreview/openreview-api/pull/1018

@celestemartinez
Copy link
Copy Markdown
Member Author

celestemartinez commented Mar 26, 2026

@melisabok before I talk to Xukun about changes to the UI, just want to make sure this looks good and it's something we want to do.

Comment thread openreview/journal/invitation.py Outdated
@celestemartinez
Copy link
Copy Markdown
Member Author

@carlosmondra I am getting an error with your minValidState PR here when trying to post a tag to a blocked profile:

'message': 'profile ~Lina_First1 has "Blocked" state which does not meet the minimum required state of undefined'

Is this something that needs to be changed in the invitation?

@celestemartinez celestemartinez marked this pull request as ready for review April 3, 2026 14:12
Copilot AI review requested due to automatic review settings April 3, 2026 14:12
Comment thread .circleci/config.yml Outdated
openreview-api-v2-branch:
type: string
default: "main"
default: "feature/new-state-keyword"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be changed back to main before merging.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a journal setting to enforce a minimum allowed profile validity state for authorids on the submission invitation, with integration tests covering Active vs Inactive behavior.

Changes:

  • Added min_profile_valid_state support to journal settings via a new Journal.get_min_profile_valid_state() accessor.
  • Updated submission invitation generation to set authorids.value.param.minValidState when configured.
  • Added end-to-end tests validating profile-state enforcement for Active and Inactive minimum states.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
openreview/journal/journal.py Adds a settings accessor for the new min_profile_valid_state option.
openreview/journal/invitation.py Applies the configured minimum profile state to the submission invitation’s authorids field.
tests/test_journal_active_profiles.py New tests exercising acceptance/rejection behavior under Active and Inactive minimum profile states.
.circleci/config.yml Changes the default checked-out OpenReview API v2 branch used in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .circleci/config.yml Outdated
Comment thread tests/test_journal_active_profiles.py Outdated
Comment thread tests/test_journal_active_profiles.py
Copy link
Copy Markdown
Member

@melisabok melisabok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@melisabok
Copy link
Copy Markdown
Member

@celestemartinez let's merge the API PR and then we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants