Feat/ Journal: add option to allow only active profiles#2968
Feat/ Journal: add option to allow only active profiles#2968celestemartinez wants to merge 13 commits intomasterfrom
Conversation
|
|
|
@carlosmondra I am getting an error with your minValidState PR here when trying to post a tag to a blocked profile: Is this something that needs to be changed in the invitation? |
| openreview-api-v2-branch: | ||
| type: string | ||
| default: "main" | ||
| default: "feature/new-state-keyword" |
There was a problem hiding this comment.
This has to be changed back to main before merging.
There was a problem hiding this comment.
Pull request overview
Adds a journal setting to enforce a minimum allowed profile validity state for authorids on the submission invitation, with integration tests covering Active vs Inactive behavior.
Changes:
- Added
min_profile_valid_statesupport to journal settings via a newJournal.get_min_profile_valid_state()accessor. - Updated submission invitation generation to set
authorids.value.param.minValidStatewhen configured. - Added end-to-end tests validating profile-state enforcement for
ActiveandInactiveminimum states.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
openreview/journal/journal.py |
Adds a settings accessor for the new min_profile_valid_state option. |
openreview/journal/invitation.py |
Applies the configured minimum profile state to the submission invitation’s authorids field. |
tests/test_journal_active_profiles.py |
New tests exercising acceptance/rejection behavior under Active and Inactive minimum profile states. |
.circleci/config.yml |
Changes the default checked-out OpenReview API v2 branch used in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@celestemartinez let's merge the API PR and then we can merge this PR. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR adds an option to the journal to force active profiles.
It also tests both these:
-profile[] with minValidState: 'Active' rejects Blocked, Limited, Rejected profiles; allows Active
-profile[] with minValidState: 'Inactive' rejects Blocked; allows Limited, Active, Rejected profiles
Depends on https://github.com/openreview/openreview-api/pull/1018