Conversation
There was a problem hiding this comment.
Pull request overview
Adds an ARR-specific preprocess script for Official_Comment notes to block link-containing comments when they are visible to authors, and updates the ARR venue configuration and tests accordingly.
Changes:
- Add
openreview/arr/process/comment_pre_process.jsto enforce “no links” for author-visible official comments (while preserving mandatory-reader checks). - Configure ARR’s
comment_stageto use the new preprocess script. - Extend
test_author_responseto assert link blocking for author-visible official comments and allow links for non-author-visible internal comments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_arr_venue_v2.py | Adds regression coverage for link-blocking behavior in Official_Comment when authors are readers. |
| openreview/arr/process/comment_pre_process.js | Implements ARR-specific preprocess logic to detect links and reject author-visible official comments containing them. |
| openreview/arr/arr.py | Wires the ARR comment stage to use the new preprocess script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const commentText = note.content?.comment?.value || "" | ||
| const linkPattern = /https?:\/\//i | ||
|
|
||
| if ((readers.includes(authorGroupId) || readers.includes("everyone")) && linkPattern.test(commentText)) { |
There was a problem hiding this comment.
have you tried setting a regex in the comment field of the Official_Comment invitation?
There was a problem hiding this comment.
The regex would apply to all comments, so this would disallow links in comments between reviewers/ACs/SACs right? The request is "authors could be prevented from submitting responses to reviewers" which I think needs extra logic
| const authorsName = domain.content?.authors_name?.value || "Authors" | ||
| const authorGroupId = `${domain.id}/Submission${forum.number}/${authorsName}` | ||
| const commentText = note.content?.comment?.value || "" | ||
| const linkPattern = /https?:\/\//i |
There was a problem hiding this comment.
We still need to allow links to the openreview site.
There was a problem hiding this comment.
I still don't think this validation is good enough, anyone can add a link without https?, what is the purpose of this validation?
This PR adds a pre-process for the ARR official comment to prevent links being sent to and from authors. The check is just for http/https as requested in the feature request