-
Notifications
You must be signed in to change notification settings - Fork 36
ARR: Add additional submission query params #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haroldrubio
wants to merge
12
commits into
master
Choose a base branch
from
fix/arr-query-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f0742b8
Add new query params
haroldrubio 1c20b2b
Change webfield code
haroldrubio d3a16bd
Update names
haroldrubio 4367d92
Merge branch 'master' into fix/arr-query-params
haroldrubio a671399
Fix brackets
haroldrubio 0243c84
Modify tests
haroldrubio 2713a84
Merge branch 'master' into fix/arr-query-params
haroldrubio 11eb038
Change all to AC filters
haroldrubio 12b6d48
Remove data assertions
haroldrubio 8e483b8
Merge branch 'master' into fix/arr-query-params
haroldrubio 3e5aaa7
Remove new lines
haroldrubio 227f674
Address Copilot
haroldrubio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,182 @@ return { | |
| return hasReply; | ||
| }) | ||
| return metaReviewReplies?.length??0; | ||
| `, | ||
| reviewerEmergencyDeclarationCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const reviewers = row.reviewers ?? []; | ||
| const signatureToReviewerIndex = new Map(); | ||
| const reviewersWithEmergencyDeclaration = new Set(); | ||
|
|
||
| reviewers.forEach((reviewer, reviewerIndex) => { | ||
| if (reviewer?.anonymizedGroup) { | ||
| signatureToReviewerIndex.set(reviewer.anonymizedGroup, reviewerIndex); | ||
| } | ||
| if (reviewer?.preferredId) { | ||
| signatureToReviewerIndex.set(reviewer.preferredId, reviewerIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isEmergencyDeclaration = (reply?.invitations ?? []).some(invitation => invitation.includes('Emergency_Declaration')); | ||
|
|
||
| if (!isEmergencyDeclaration || !signatureToReviewerIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| reviewersWithEmergencyDeclaration.add(signatureToReviewerIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return reviewersWithEmergencyDeclaration.size; | ||
| `, | ||
| areaChairEmergencyDeclarationCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const areaChairs = row.metaReviewData?.areaChairs ?? []; | ||
| const signatureToAreaChairIndex = new Map(); | ||
| const areaChairsWithEmergencyDeclaration = new Set(); | ||
|
|
||
| areaChairs.forEach((areaChair, areaChairIndex) => { | ||
| if (areaChair?.anonymizedGroup) { | ||
| signatureToAreaChairIndex.set(areaChair.anonymizedGroup, areaChairIndex); | ||
| } | ||
| if (areaChair?.preferredId) { | ||
| signatureToAreaChairIndex.set(areaChair.preferredId, areaChairIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isEmergencyDeclaration = (reply?.invitations ?? []).some(invitation => invitation.includes('Emergency_Declaration')); | ||
|
|
||
| if (!isEmergencyDeclaration || !signatureToAreaChairIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| areaChairsWithEmergencyDeclaration.add(signatureToAreaChairIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return areaChairsWithEmergencyDeclaration.size; | ||
| `, | ||
| reviewerDelayNotificationCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const reviewers = row.reviewers ?? []; | ||
| const signatureToReviewerIndex = new Map(); | ||
| const reviewersWithDelayNotification = new Set(); | ||
|
|
||
| reviewers.forEach((reviewer, reviewerIndex) => { | ||
| if (reviewer?.anonymizedGroup) { | ||
| signatureToReviewerIndex.set(reviewer.anonymizedGroup, reviewerIndex); | ||
| } | ||
| if (reviewer?.preferredId) { | ||
| signatureToReviewerIndex.set(reviewer.preferredId, reviewerIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isDelayNotification = (reply?.invitations ?? []).some(invitation => invitation.includes('Delay_Notification')); | ||
|
|
||
| if (!isDelayNotification || !signatureToReviewerIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| reviewersWithDelayNotification.add(signatureToReviewerIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return reviewersWithDelayNotification.size; | ||
| `, | ||
| areaChairDelayNotificationCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const areaChairs = row.metaReviewData?.areaChairs ?? []; | ||
| const signatureToAreaChairIndex = new Map(); | ||
| const areaChairsWithDelayNotification = new Set(); | ||
|
|
||
| areaChairs.forEach((areaChair, areaChairIndex) => { | ||
| if (areaChair?.anonymizedGroup) { | ||
| signatureToAreaChairIndex.set(areaChair.anonymizedGroup, areaChairIndex); | ||
| } | ||
| if (areaChair?.preferredId) { | ||
| signatureToAreaChairIndex.set(areaChair.preferredId, areaChairIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isDelayNotification = (reply?.invitations ?? []).some(invitation => invitation.includes('Delay_Notification')); | ||
|
|
||
| if (!isDelayNotification || !signatureToAreaChairIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| areaChairsWithDelayNotification.add(signatureToAreaChairIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return areaChairsWithDelayNotification.size; | ||
| `, | ||
| assignedReviewersAfterEmergencyDeclarationsCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const reviewers = row.reviewers ?? []; | ||
| const signatureToReviewerIndex = new Map(); | ||
| const reviewersWithEmergencyDeclaration = new Set(); | ||
|
|
||
| reviewers.forEach((reviewer, reviewerIndex) => { | ||
| if (reviewer?.anonymizedGroup) { | ||
| signatureToReviewerIndex.set(reviewer.anonymizedGroup, reviewerIndex); | ||
| } | ||
| if (reviewer?.preferredId) { | ||
| signatureToReviewerIndex.set(reviewer.preferredId, reviewerIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isEmergencyDeclaration = (reply?.invitations ?? []).some(invitation => invitation.includes('Emergency_Declaration')); | ||
|
|
||
| if (!isEmergencyDeclaration || !signatureToReviewerIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| reviewersWithEmergencyDeclaration.add(signatureToReviewerIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return Math.max(0, reviewers.length - reviewersWithEmergencyDeclaration.size); | ||
| `, | ||
|
||
| completedReviewsOrDelayNotificationsCount: ` | ||
| const replies = row.note?.details?.replies ?? []; | ||
| const reviewers = row.reviewers ?? []; | ||
| const officialReviews = row.officialReviews ?? []; | ||
| const signatureToReviewerIndex = new Map(); | ||
| const reviewersWithDelayNotification = new Set(); | ||
| const reviewersWithOfficialReview = new Set( | ||
| officialReviews | ||
| .map(review => review?.anonymousId) | ||
| .filter(Boolean) | ||
| ); | ||
|
|
||
| reviewers.forEach((reviewer, reviewerIndex) => { | ||
| if (reviewer?.anonymizedGroup) { | ||
| signatureToReviewerIndex.set(reviewer.anonymizedGroup, reviewerIndex); | ||
| } | ||
| if (reviewer?.preferredId) { | ||
| signatureToReviewerIndex.set(reviewer.preferredId, reviewerIndex); | ||
| } | ||
| }); | ||
|
|
||
| replies.forEach(reply => { | ||
| const replySignature = reply?.signatures?.[0]; | ||
| const isDelayNotification = (reply?.invitations ?? []).some(invitation => invitation.includes('Delay_Notification')); | ||
|
|
||
| if (!isDelayNotification || !signatureToReviewerIndex.has(replySignature)) { | ||
| return; | ||
| } | ||
|
|
||
| reviewersWithDelayNotification.add(signatureToReviewerIndex.get(replySignature)); | ||
| }); | ||
|
|
||
| return reviewers.filter((reviewer, reviewerIndex) => { | ||
| return reviewersWithOfficialReview.has(reviewer?.anonymousId) || reviewersWithDelayNotification.has(reviewerIndex); | ||
| }).length; | ||
|
||
| ` | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
completedReviewsPlusDelayNotificationsCountimplementation counts unique assigned reviewers who either submitted an official review OR submitted a delay notification (it does not add the two counts, and it won’t double-count a reviewer who did both). This behavior doesn’t match the PR description wording (“plus”), and thePlusname is misleading given the OR/union semantics. Consider either renaming to reflect OR/union semantics (and aligning with the SAC console param name), or adjusting the computation if a true sum is required.