ARR: Validate camera-ready against TeX/Markdown#3001
Draft
haroldrubio wants to merge 10 commits intomasterfrom
Draft
ARR: Validate camera-ready against TeX/Markdown#3001haroldrubio wants to merge 10 commits intomasterfrom
haroldrubio wants to merge 10 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds camera-ready (submission revision stage) validation to disallow TeX and Markdown markup in title/abstract, along with an integration test that configures and exercises the new preprocess behavior in an ARR venue workflow.
Changes:
- Extend
test_commitment_venueto create aCamera_Ready_Revisionstage, attach revision preprocess scripts, and verify rejection/acceptance cases. - Add a JS preprocess wrapper that loads
revision_preprocess_scriptfrom the meta invitation and executes it. - Add the actual validation script that detects TeX/Markdown patterns in
titleandabstractand raises user-facing errors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_arr_venue_v2.py | Adds end-to-end coverage for camera-ready revision validation and expected error behavior. |
| openreview/arr/process/camera_ready_preprocess.js | JS preprocess wrapper that fetches and executes revision_preprocess_script from the meta invitation. |
| openreview/arr/process/camera_ready_preprocess_content.js | Implements TeX/Markdown detection rules for title/abstract and returns OpenReviewErrors on violations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates two files to perform TeX/Markdown validation for a submission revision stage, typically the camera-ready revision
Edit: Waiting on feedback from ARR before proceeding with implementation