Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ARR workflow setup to automatically prune the global active_venues group so that only the latest two ARR cycles remain listed, and adds a regression test to validate the pruning behavior during an ARR cycle deployment.
Changes:
- Add
ARR.prune_active_arr_venues()and call it fromARR.setup(). - Introduce a test that seeds
active_venueswith stale ARR venues and asserts only the latest two remain after deploy/setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
openreview/arr/arr.py |
Adds ARR-specific pruning logic and invokes it during venue setup. |
tests/test_arr_venue_v2.py |
Adds coverage ensuring stale ARR venues are removed from active_venues after setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if venue_group is None: | ||
| continue | ||
| venue_cdate = venue_group.cdate | ||
| arr_venues.append((venue_cdate, venue_id == self.venue_id, venue_id)) |
There was a problem hiding this comment.
What is the purpose of saving venue_id == self.venue_id?
There was a problem hiding this comment.
to know if that venue is the current cycle?
There was a problem hiding this comment.
yes, I thought so, but I guess I don't see it being used anywhere. Maybe I am missing something
| return | ||
|
|
||
| arr_venues.sort(reverse=True) | ||
| stale_venue_ids = [venue_id for _, _, venue_id in arr_venues[keep_count:]] |
There was a problem hiding this comment.
@celestemartinez here we should filter out the current cycle.
There was a problem hiding this comment.
I can make the change to do it more explicitly
This PR adds a step in the
setupfunction in the ARR class to keep only the most recent 2 cycles inactive_venues