Skip to content

Add tests review revision tests form multiple review forms#3026

Open
enrubio wants to merge 6 commits intomasterfrom
fix/add-tests-review-revision
Open

Add tests review revision tests form multiple review forms#3026
enrubio wants to merge 6 commits intomasterfrom
fix/add-tests-review-revision

Conversation

@enrubio
Copy link
Copy Markdown
Member

@enrubio enrubio commented Apr 17, 2026

This PR adds tests for multiple review forms with review revisions. Specifically the case where the parent invitation names differ and they share the same child invitation name for both the review invitations and the review revision invitations.

@enrubio enrubio marked this pull request as ready for review April 21, 2026 13:59
Copilot AI review requested due to automatic review settings April 21, 2026 13:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression coverage for ICML conference workflows where multiple review-revision forms share the same child invitation name (Review_Revision) but differ by parent invitation name and submission query (position vs non-position track), ensuring invitations and posted revisions don’t overwrite each other.

Changes:

  • Add test_review_revision_multiple_forms covering two concurrent custom revision stages with shared child_invitations_name.
  • Extend an existing edits/readers assertion loop to skip Review_Revision note edits (which don’t include edit.note.readers).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_icml_conference.py Outdated
Comment thread tests/test_icml_conference.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants