Fix spr_eear to save appropriate value for each exception - #108
Conversation
|
Thanks @JaewonHur , I can't verify this did right now but I'm working on it. Sorry for delaying. I hope we can get all these fixes in. |
| if (except_ibus_err_i | except_itlb_miss_i | except_ipagefault_i | except_illegal_i) | ||
| spr_eear <= pc_ctrl_i; | ||
| else | ||
| else if (except_dbus_i | except_dtlb_miss_i | except_dpagefault_i | except_align_i) |
There was a problem hiding this comment.
why is this needed?
either this list is covering all the cases that are not covered in the previous if and then it is superfluous,
or it does not contain all the cases that are not covered in the previous if and then it is wrong
There was a problem hiding this comment.
I agree, with verilog we should always have an else case otherwise the logic is incomplete. Also, the reason I am looking at this is because I noticed during linux debugging with mor1kx the trap instructions are appearing to have incorrect EEAR set. The trap case doesn't seem to be handler here, maybe its somewhere else?
There was a problem hiding this comment.
Well, my comment is wrong here l.trap doesn't set eear as per spec.
3 participants
This will resolve #99