fix(egress): make credential vault mutations immediately visible - #1755
Merged
Pangjiping merged 3 commits intoSep 8, 2026
Merged
Conversation
Gujiassh
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
September 7, 2026 23:36
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Gujiassh
force-pushed
the
fix/credential-vault-ack-visibility
branch
from
September 7, 2026 23:37
13e8963 to
fd5e4e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
304reuses the snapshot,200validates and replaces it, and404alone means no active vault1503, while streamed requests terminate before upstream forwardingWhy
#1281 removes an unrelated one-second execd delay. An immediate request can therefore reuse the pre-mutation egress snapshot after the Credential Vault mutation returned success.
The Store publishes the tag with mutation state under one lock. Conditional comparison and snapshot rendering share one read lock, preventing mixed-version responses.
Relationship to #1636
This overlaps #1636 only in fail-closed lookup handling. The main change is the ACK-visibility protocol across the Go Store, sidecar/fleet handlers, per-client fleet cache, and Python addon. It also covers malformed payloads, cache clearing, status preservation, streamed-body termination, and operator documentation. It stays separate from #1281 so its approved execd scope remains unchanged.
Validation
mitmdump/AF_UNIX)go vetpassedgit diff --checkpassedACCEPTCI required before merge
Please require native Ubuntu egress/mitmdump/AF_UNIX tests, fleet smoke, native Go checks, and Docker-bridge multilingual Credential Vault E2E.