PPL Alerting: PPL Dependencies and Utils#2114
Open
toepkerd wants to merge 3 commits intoopensearch-project:mainfrom
Open
PPL Alerting: PPL Dependencies and Utils#2114toepkerd wants to merge 3 commits intoopensearch-project:mainfrom
toepkerd wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
lezzago
reviewed
May 1, 2026
| Setting.Property.NodeScope, Setting.Property.Dynamic | ||
| ) | ||
|
|
||
| val NOTIFICATION_SUBJECT_SOURCE_MAX_LENGTH = Setting.intSetting( |
Member
There was a problem hiding this comment.
Is this part of a bug fix? Wouldnt adding this validation cause a breaking change?
Collaborator
Author
There was a problem hiding this comment.
These checks are only made against PPL Triggers when PPL Monitors are being created, they're not applied to existing Monitor types.
Collaborator
Author
There was a problem hiding this comment.
lezzago
reviewed
May 1, 2026
| Setting.Property.NodeScope, Setting.Property.Dynamic | ||
| ) | ||
|
|
||
| val NOTIFICATION_MESSAGE_SOURCE_MAX_LENGTH = Setting.intSetting( |
Member
There was a problem hiding this comment.
Is this part of a bug fix? Wouldnt adding this validation cause a breaking change?
Collaborator
Author
There was a problem hiding this comment.
These checks are only made against PPL Triggers when PPL Monitors are being created, they're not applied to existing Monitor types.
Collaborator
Author
There was a problem hiding this comment.
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
toepkerd
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
manaswini1920,
nishtham-amazon,
rishabhmaurya,
riysaxen-amzn and
vikhy-aws
as code owners
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.