Add PR job analysis to LVMS doctor skill#237
Conversation
The LVMS doctor SKILL.md only instructed the LLM to analyze release jobs, skipping PR jobs entirely. This meant no prs-job-*.json files were created, so finalize never ran PR aggregation and prs-summary.json was never produced. The Pull Requests tab showed pass/fail counts but no failure detail cards. Align Step 2 with microshift-ci: analyze PR jobs alongside release jobs, save output as prs-job-<N>-pr<PR>-<SUFFIX>.json so finalize finds them and produces prs-summary.json for the report. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesLVMS-CI doctor updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/lvms-ci/.claude-plugin/plugin.json`:
- Line 4: Update the lvms-ci entry in .claude-plugin/marketplace.json to version
1.2.1, matching the version declared in the plugin.json metadata.
In `@plugins/lvms-ci/skills/doctor/SKILL.md`:
- Around line 123-125: Update the deterministic script-output documentation to
name the PR summary file as prs-summary.json instead of the generic
summary.json, matching the finalize and HTML-report implementation while
preserving the release summary naming.
- Around line 77-78: Update the PR failed-job condition in the instructions
around launching separate Agents to recognize both documented status spellings,
failure and FAILURE, by normalizing the status before comparison or explicitly
accepting both values; continue excluding non-failure PR jobs.
- Around line 101-104: Update the per-agent response handling before the Write
tool calls in the release and PR job flows to validate that the response exists,
contains no agent error, and parses as a JSON array. When validation fails,
record the affected job and skip writing its aggregation input, while continuing
through the mandatory finalize step; only write validated array responses to the
corresponding release or PR job file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 898c0206-43df-4fa2-b238-7d903bc48b54
📒 Files selected for processing (2)
plugins/lvms-ci/.claude-plugin/plugin.jsonplugins/lvms-ci/skills/doctor/SKILL.md
Match the plugin.json version bump to fix check-version-bump CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Accept both failure and FAILURE status spellings when filtering PR jobs. Correct finalize documentation to name actual output files: release-<version>-summary.json and prs-summary.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test eval-all |
Summary
prs-job-*.jsonfiles were created, sofinalizenever ran PR aggregationprs-summary.json)prs-job-<N>-pr<PR>-<SUFFIX>.jsonTest plan
/lvms-ci:doctor 4.18locally with the updated SKILL.mdprs-summary.jsonis now produced by finalize (=== Aggregating PRs ===found 30 PR job files)🤖 Generated with Claude Code
Summary by CodeRabbit