Skip to content

Add PR job analysis to LVMS doctor skill#237

Open
kasturinarra wants to merge 4 commits into
openshift-eng:mainfrom
kasturinarra:fix-lvms-doctor-pr-analysis
Open

Add PR job analysis to LVMS doctor skill#237
kasturinarra wants to merge 4 commits into
openshift-eng:mainfrom
kasturinarra:fix-lvms-doctor-pr-analysis

Conversation

@kasturinarra

@kasturinarra kasturinarra commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • LVMS doctor SKILL.md only analyzed release jobs, skipping PR jobs entirely
  • No prs-job-*.json files were created, so finalize never ran PR aggregation
  • Pull Requests tab showed pass/fail counts but no failure detail cards (missing prs-summary.json)
  • Aligned Step 2 with microshift-ci: PR jobs are now analyzed and saved as prs-job-<N>-pr<PR>-<SUFFIX>.json

Test plan

  • Ran /lvms-ci:doctor 4.18 locally with the updated SKILL.md
  • Verified prs-summary.json is now produced by finalize (=== Aggregating PRs === found 30 PR job files)
  • Confirmed Pull Requests tab in HTML report shows failure detail cards with severity, root cause, and remediation

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Expanded CI troubleshooting guidance to cover failed pull request jobs alongside scheduled release jobs.
    • Added instructions for identifying, processing, and summarizing pull request failures.
    • Documented pull request job fields, output files, and status reporting.
  • Chores
    • Updated the CI plugin version to 1.2.1.

The LVMS doctor SKILL.md only instructed the LLM to analyze release
jobs, skipping PR jobs entirely. This meant no prs-job-*.json files
were created, so finalize never ran PR aggregation and prs-summary.json
was never produced. The Pull Requests tab showed pass/fail counts but
no failure detail cards.

Align Step 2 with microshift-ci: analyze PR jobs alongside release
jobs, save output as prs-job-<N>-pr<PR>-<SUFFIX>.json so finalize
finds them and produces prs-summary.json for the report.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@kasturinarra, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 74543f0d-222c-4e71-87be-f5ccf5aab8ed

📥 Commits

Reviewing files that changed from the base of the PR and between d2a0523 and 6d9e7b9.

📒 Files selected for processing (1)
  • plugins/lvms-ci/skills/doctor/SKILL.md

Walkthrough

The lvms-ci:doctor documentation now covers PR job collection, failure-only analysis, aggregation, and reporting. The plugin version is incremented from 1.2.0 to 1.2.1 in both manifests.

Changes

LVMS-CI doctor updates

Layer / File(s) Summary
Document PR job processing
plugins/lvms-ci/skills/doctor/SKILL.md
Documents PR job outputs, fields, failure filtering, agent prompts, persisted reports, aggregation, and status reporting.
Bump plugin metadata versions
plugins/lvms-ci/.claude-plugin/plugin.json, .claude-plugin/marketplace.json
Updates the lvms-ci plugin version from 1.2.0 to 1.2.1 in both manifests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning PR mentions Claude Code and the commits use Co-Authored-By, but no Assisted-by/Generated-by trailers are present. Replace AI-related Co-Authored-By trailers with Red Hat-style Assisted-by or Generated-by trailers on the affected commits.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding PR job analysis to the LVMS doctor skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed Changed files are docs/version-only, and scans found no MD5/SHA1/DES/RC4/3DES, custom crypto, or secret comparisons in the lvms-ci subtree.
Container-Privileges ✅ Passed The diff only changes a markdown skill file; no container/K8s manifests or privilege flags (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) are present.
No-Sensitive-Data-In-Logs ✅ Passed Only SKILL.md changed; it adds workflow docs and no logs or secret/PII-bearing messages were introduced.
No-Hardcoded-Secrets ✅ Passed No API keys, tokens, passwords, private keys, credentialed URLs, or long base64 strings were present in the changed files.
No-Injection-Vectors ✅ Passed Only SKILL.md changed; no eval/exec, shell=True, yaml.load, pickle.loads, os.system, or dangerouslySetInnerHTML appeared in the modified files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/lvms-ci/.claude-plugin/plugin.json`:
- Line 4: Update the lvms-ci entry in .claude-plugin/marketplace.json to version
1.2.1, matching the version declared in the plugin.json metadata.

In `@plugins/lvms-ci/skills/doctor/SKILL.md`:
- Around line 123-125: Update the deterministic script-output documentation to
name the PR summary file as prs-summary.json instead of the generic
summary.json, matching the finalize and HTML-report implementation while
preserving the release summary naming.
- Around line 77-78: Update the PR failed-job condition in the instructions
around launching separate Agents to recognize both documented status spellings,
failure and FAILURE, by normalizing the status before comparison or explicitly
accepting both values; continue excluding non-failure PR jobs.
- Around line 101-104: Update the per-agent response handling before the Write
tool calls in the release and PR job flows to validate that the response exists,
contains no agent error, and parses as a JSON array. When validation fails,
record the affected job and skip writing its aggregation input, while continuing
through the mandatory finalize step; only write validated array responses to the
corresponding release or PR job file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 898c0206-43df-4fa2-b238-7d903bc48b54

📥 Commits

Reviewing files that changed from the base of the PR and between 6b92924 and de5bf23.

📒 Files selected for processing (2)
  • plugins/lvms-ci/.claude-plugin/plugin.json
  • plugins/lvms-ci/skills/doctor/SKILL.md

Comment thread plugins/lvms-ci/.claude-plugin/plugin.json
Comment thread plugins/lvms-ci/skills/doctor/SKILL.md
Comment thread plugins/lvms-ci/skills/doctor/SKILL.md
Comment thread plugins/lvms-ci/skills/doctor/SKILL.md
kasturinarra and others added 2 commits July 23, 2026 13:19
Match the plugin.json version bump to fix check-version-bump CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Accept both failure and FAILURE status spellings when filtering PR jobs.
Correct finalize documentation to name actual output files:
release-<version>-summary.json and prs-summary.json.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 23, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kasturinarra

Copy link
Copy Markdown
Contributor Author

/test eval-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant