USHIFT-7381: fix(microshift-ci): fix PCP dashboard rendering inside Spyglass

[suleymanakbas91]

Summary

• Replace height: 100vh; overflow: hidden with html,body { height: 100% } and min-height: 600px on body
• Replace height: 60vh on empty-state with fixed 400px
• Spyglass embeds custom-link HTML in a container where 100vh resolves to 0, causing the dashboard to render as a blank page

Test plan

• Generate dashboard locally and open in browser — layout works as before
• Merge and wait for CI image rebuild, then verify rehearsal job shows dashboard content in Spyglass

🤖 Generated with Claude Code

Summary by CodeRabbit

• Style
  • Updated dashboard page layout sizing for more consistent display across screen dimensions.
  • Adjusted the empty-state panel height for a stable, predictable presentation.
• Chores
  • Bumped the microshift-ci plugin version to 1.5.1.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 5118855 to 9860fe3.

Walkthrough

The PCP dashboard layout now uses full-height sizing with a 600px minimum and a fixed 400px empty-state height. Hypervisor build ID extraction uses an artifacts-relative path. The microshift-ci plugin version is updated to 1.5.1.

Changes

Microshift CI updates

Layer / File(s)	Summary
Dashboard layout and build ID handling plugins/microshift-ci/scripts/pcp-graphs/create-pcp-dashboard.py, plugins/microshift-ci/scripts/pcp-graphs/generate-dashboard.sh	Updates dashboard sizing and empty-state dimensions, and derives hypervisor build IDs from the artifacts-relative path.
Plugin version metadata .claude-plugin/marketplace.json, plugins/microshift-ci/.claude-plugin/plugin.json	Updates the microshift-ci plugin version from 1.5.0 to 1.5.1 in marketplace and manifest metadata.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openshift-eng/edge-tooling#238: Refactors related build ID and path handling in generate-dashboard.sh.

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ai-Attribution	⚠️ Warning	AI use is explicit, but the commits only use Co-Authored-By: Claude Opus 4.6; no Assisted-by/Generated-by trailers were found.	Amend the AI-assisted commits to use Red Hat’s Assisted-by or Generated-by trailers and remove Co-Authored-By for AI tooling.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main user-facing change: fixing PCP dashboard rendering inside Spyglass.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto	✅ Passed	Changed files only adjust CSS, path parsing, and version metadata; precise scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-comparison code.
Container-Privileges	✅ Passed	Only a shell script changed; no container/K8s manifests or privilege fields (privileged, hostPID, hostNetwork, allowPrivilegeEscalation, SYS_ADMIN) were present.
No-Sensitive-Data-In-Logs	✅ Passed	Status/info messages only; PR changes CSS, versions, and path parsing. No new logging of passwords, tokens, PII, hostnames, or customer data.
No-Hardcoded-Secrets	✅ Passed	PR changes only CSS, version bumps, and path parsing; no secret-like literals, credentials, private keys, or long base64 strings were added.
No-Injection-Vectors	✅ Passed	No new injection sinks found: the PR changes CSS/version metadata and a shell path parse; DOM writes use textContent/escaped JSON, with no eval/os.system/shell=True.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/microshift-ci/scripts/pcp-graphs/generate-dashboard.sh`:
- Around line 264-265: Add tests for the build_id extraction in the
generate-dashboard flow, covering positive numeric IDs, the literal “local”
identifier, and malformed artifact-relative paths. Verify each case produces the
expected grouping key, including rejection or handling of invalid paths
according to the existing script behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 726231b7-0755-4e68-804a-52213b7530cc

📥 Commits

Reviewing files that changed from the base of the PR and between ff6418a and 0e90bb4.

📒 Files selected for processing (1)

• plugins/microshift-ci/scripts/pcp-graphs/generate-dashboard.sh

[agullon]

/lgtm