Fix group write permissions on CI image workdir#241
Conversation
OpenShift CI assigns a random UID in the root group. Without g+rwx on the workdir, the eval harness cannot create eval/runs/ and falls back to /tmp, causing reports to be missing from artifacts. Matches the chmod pattern used in the ai-helpers base image. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughThe CI container build now recursively grants group read, write, and execute permissions to ChangesContainer build permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@images/Containerfile.ci`:
- Line 8: Update the permission command following the repository setup to limit
recursive group-write access to the required eval/runs directories, or otherwise
replace g+rwx with g+rwX so regular files do not gain execute permissions;
preserve only the shared access needed by those directories.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce595d40-21a1-47af-8ced-f733a5b40a08
📒 Files selected for processing (1)
images/Containerfile.ci
|
/lgtm |
Summary
g+rwxon/opt/app-root/src/edge-tooling, the eval harness gets "Permission denied" creatingeval/runs/and falls back to/tmpcopy_artifactstrap then finds no reports at the expected path, soreport.htmlandsummary.yamlare missing from Spyglass artifactschmod -R g+rwxmatching the same pattern used in the ai-helpers base imageTest plan
/test eval-allon an edge-tooling PRreport.htmlandsummary.yamlappear in Spyglass artifacts🤖 Generated with Claude Code
Summary by CodeRabbit