Skip to content

Fix group write permissions on CI image workdir#241

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
kasturinarra:fix-containerfile-permissions
Jul 24, 2026
Merged

Fix group write permissions on CI image workdir#241
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
kasturinarra:fix-containerfile-permissions

Conversation

@kasturinarra

@kasturinarra kasturinarra commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • OpenShift CI assigns a random UID in the root group. Without g+rwx on /opt/app-root/src/edge-tooling, the eval harness gets "Permission denied" creating eval/runs/ and falls back to /tmp
  • The copy_artifacts trap then finds no reports at the expected path, so report.html and summary.yaml are missing from Spyglass artifacts
  • Adds chmod -R g+rwx matching the same pattern used in the ai-helpers base image

Test plan

  • After merge + image rebuild, run /test eval-all on an edge-tooling PR
  • Verify report.html and summary.yaml appear in Spyglass artifacts

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved shared access permissions for application files in CI build environments.

OpenShift CI assigns a random UID in the root group. Without g+rwx
on the workdir, the eval harness cannot create eval/runs/ and falls
back to /tmp, causing reports to be missing from artifacts.

Matches the chmod pattern used in the ai-helpers base image.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The CI container build now recursively grants group read, write, and execute permissions to /opt/app-root/src/edge-tooling after copying repository contents.

Changes

Container build permissions

Layer / File(s) Summary
Apply repository group permissions
images/Containerfile.ci
Adds a recursive chmod -R g+rwx step for the copied repository path.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning PR/commit mention Claude Code, but the only AI attribution trailer is Co-Authored-By; no Assisted-by or Generated-by trailer is present. Replace the AI Co-Authored-By trailer with the required Red Hat attribution trailer (Assisted-by: or Generated-by:) in the commit/PR metadata.
No-Weak-Crypto ❓ Inconclusive placeholder2 need investigation
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to add group write permissions in the CI image workdir.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Container-Privileges ✅ Passed No privileged/K8s security flags were found; the only root use is USER 0:0 in the build Containerfile for chmod/dnf, which is justified.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a chmod line; it introduces no new logging or secret-bearing output.
No-Hardcoded-Secrets ✅ Passed PR only adds a chmod line; no hardcoded secrets, tokens, passwords, or credentialed URLs appear in the diff.
No-Injection-Vectors ✅ Passed The PR only adds a chmod line in images/Containerfile.ci; no SQL/shell/eval/pickle/yaml/innerHTML sinks are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@images/Containerfile.ci`:
- Line 8: Update the permission command following the repository setup to limit
recursive group-write access to the required eval/runs directories, or otherwise
replace g+rwx with g+rwX so regular files do not gain execute permissions;
preserve only the shared access needed by those directories.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ce595d40-21a1-47af-8ced-f733a5b40a08

📥 Commits

Reviewing files that changed from the base of the PR and between 97e1bfb and 6c554b5.

📒 Files selected for processing (1)
  • images/Containerfile.ci

Comment thread images/Containerfile.ci
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 24, 2026
@jeff-roche

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 81f6a9f into openshift-eng:main Jul 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants