Skip to content

PROOF: certrotation refactor + configurable PKI support#2087

Closed
sanchezl wants to merge 4 commits into
openshift:mainfrom
sanchezl:certrotation-refactor-proof
Closed

PROOF: certrotation refactor + configurable PKI support#2087
sanchezl wants to merge 4 commits into
openshift:mainfrom
sanchezl:certrotation-refactor-proof

Conversation

@sanchezl

@sanchezl sanchezl commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • go build ./... passes
  • e2e with TechPreview ConfigurablePKI

@coderabbitai

coderabbitai Bot commented Apr 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 332e573c-4985-4fc9-8d51-4a289f6846b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci

openshift-ci Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@sanchezl
sanchezl force-pushed the certrotation-refactor-proof branch from dc679a7 to 4cbcb36 Compare April 2, 2026 20:34
@sanchezl
sanchezl force-pushed the certrotation-refactor-proof branch from 4cbcb36 to f40668e Compare April 3, 2026 02:07
@sanchezl sanchezl changed the title PROOF: certrotation refactor integration PROOF: certrotation refactor + configurable PKI support Apr 3, 2026
@sanchezl
sanchezl force-pushed the certrotation-refactor-proof branch 2 times, most recently from d7bc1e5 to 8f564d0 Compare April 3, 2026 20:46
@sanchezl

sanchezl commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@sanchezl
sanchezl marked this pull request as ready for review April 6, 2026 15:19
@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 6, 2026
@openshift-ci
openshift-ci Bot requested review from benluddy and dgrisonnet April 6, 2026 15:19
@sanchezl

sanchezl commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@sanchezl

sanchezl commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview

@openshift-ci

openshift-ci Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@sanchezl: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4ff07b40-32ac-11f1-8f40-e93b04c11ec9-0

@openshift-ci

openshift-ci Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-1of2 0cb0c5e link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp-operator-serial-ote 0cb0c5e link true /test e2e-gcp-operator-serial-ote

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr

gangwgr commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@sanchezl

sanchezl commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing — proof for library-go#2152 (refactor + PKI). Went with library-go#2145 + CKAO#2051 instead due to how CEO uses the certrotation package.

@sanchezl sanchezl closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants