Skip to content

Adopt conmon-rs as default container monitor#2034

Open
saschagrunert wants to merge 1 commit into
openshift:masterfrom
saschagrunert:conmon-rs-enhancement
Open

Adopt conmon-rs as default container monitor#2034
saschagrunert wants to merge 1 commit into
openshift:masterfrom
saschagrunert:conmon-rs-enhancement

Conversation

@saschagrunert

@saschagrunert saschagrunert commented Jun 5, 2026

Copy link
Copy Markdown
Member

Propose switching CRI-O from the traditional per-container conmon to the pod-level conmon-rs monitor in OpenShift.

  • Introduce ConmonRS feature gate in TechPreviewNoUpgrade
  • MCO generates CRI-O drop-in config when the gate is enabled (no new API fields)
  • Establish regular conmon-rs builds in the Node Layer (OCP-aligned versioning, >= v1.0.1)
  • Target Tech Preview in OCP 5.1 (CRI-O v1.37.0), graduate to GA over one minor release cycle
  • Status: implementable
  • Tracking: OCPNODE-1288

/cc @haircommander @rphillips

@openshift-ci
openshift-ci Bot requested review from haircommander and rphillips June 5, 2026 09:14
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch 9 times, most recently from 8c3987a to ca49d66 Compare June 5, 2026 09:54
@saschagrunert saschagrunert changed the title WIP: enhancement: adopt conmon-rs as default container monitor Adopt conmon-rs as default container monitor Jun 5, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch from ca49d66 to 672b352 Compare June 5, 2026 09:59
@saschagrunert

Copy link
Copy Markdown
Member Author

@bitoku @harche @QiWang19 PTAL, too

Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch 2 times, most recently from 5eda281 to 0b18266 Compare June 5, 2026 11:56
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch 6 times, most recently from bba7476 to 2c852b2 Compare June 8, 2026 12:32
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch from 2c852b2 to cf19ef3 Compare June 8, 2026 13:19
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch from cf19ef3 to 62ad95f Compare June 25, 2026 06:27
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch 2 times, most recently from 697b0f6 to bfb2d91 Compare July 8, 2026 07:29
@saschagrunert

saschagrunert commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Updated the enhancement to reflect upstream progress:

  • conmon-rs v1.0.1 has been vendored into CRI-O main (cri-o/cri-o#10111)
  • Retargeted from OCP 5.0 to OCP 5.1 (CRI-O v1.37.0)
  • Bumped minimum conmon-rs version to >= v1.0.1
  • Added note about the v1.0.0 breaking change (removed deprecated Cap'n Proto fields, CRI-O v1.37.0+ no longer supports older conmon-rs versions)
  • Status moved to implementable

@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch 2 times, most recently from 90b5877 to 9527d23 Compare July 8, 2026 07:35
@saschagrunert

Copy link
Copy Markdown
Member Author

@openshift/cri-o-maintainers PTAL again

Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
@haircommander

Copy link
Copy Markdown
Member

/lgtm
some notes, but none blocking

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch from 9527d23 to 39d0177 Compare July 13, 2026 06:28
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
saschagrunert force-pushed the conmon-rs-enhancement branch from 39d0177 to 975d025 Compare July 13, 2026 06:33
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saschagrunert

Copy link
Copy Markdown
Member Author

@yuqi-zhang PTAL, not a high priority one as planned for 5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants