OCPBUGS-98100: e2e: storage snapshot tests should read custom timeouts from manifest

[dobsonj]

https://redhat.atlassian.net/browse/OCPBUGS-98100

This change is needed so that timeouts specified in openshift/ibm-vpc-block-csi-driver-operator#175 will take effect during e2e tests.

/cc @openshift/storage

Summary by CodeRabbit

• Tests
  • Updated snapshot-related end-to-end tests to use storage-driver-specific timeout settings.
  • Improved test reliability across drivers with varying operation durations.

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-98100

This change is needed so that timeouts specified in openshift/ibm-vpc-block-csi-driver-operator#175 will take effect during e2e tests.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-98100, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-98100

This change is needed so that timeouts specified in openshift/ibm-vpc-block-csi-driver-operator#175 will take effect during e2e tests.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dobsonj: the contents of this pull request could be automatically validated.

The following commits are valid:

• de396e9|UPSTREAM: 140377: e2e: storage snapshot tests should read custom timeouts from manifest: the upstream PR kubernetes/kubernetes#140377 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 70cb5c63-979d-4053-b80f-f8c608c4ea44

📥 Commits

Reviewing files that changed from the base of the PR and between 78acd4d and de396e9.

📒 Files selected for processing (3)

• test/e2e/storage/testsuites/snapshot-metadata.go
• test/e2e/storage/testsuites/snapshottable.go
• test/e2e/storage/testsuites/snapshottable_stress.go

---

Walkthrough

Three storage snapshot E2E suites now initialize their frameworks with timeouts obtained from the configured storage driver instead of default framework timeouts.

Changes

Storage test timeout configuration

Layer / File(s)	Summary
Configure driver-specific suite timeouts test/e2e/storage/testsuites/snapshot-metadata.go, test/e2e/storage/testsuites/snapshottable.go, test/e2e/storage/testsuites/snapshottable_stress.go	Framework initialization now uses storageframework.GetDriverTimeouts(driver) for all three snapshot test suites.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: storage snapshot e2e tests now read custom timeouts from the manifest.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Changed hunks only switch framework timeouts; all Ginkgo titles in these files are static string literals with no dynamic values.
Test Structure And Quality	✅ Passed	Only framework init changed; the suites already use explicit timeouts and DeferCleanup/AfterEach, and the new driver-specific timeouts match repo patterns.
Microshift Test Compatibility	✅ Passed	Only timeout framework constructors changed; no new Ginkgo tests or MicroShift-unsupported OpenShift APIs/features were added in the touched suites.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only swaps framework init to custom driver timeouts; no new It/Describe/Context/When blocks or SNO-sensitive logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only framework constructors changed to use GetDriverTimeouts in three test suites; no node selectors, affinity, spread, or topology logic was added.
Ote Binary Stdout Contract	✅ Passed	Only change is swapping framework constructors; no init/TestMain/BeforeSuite stdout writes or Print/log-to-stdout calls were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The patch only swaps framework constructors to use driver timeouts; it adds no new Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	Touched lines only switch framework constructors to GetDriverTimeouts; no crypto, hash, cipher, or constant-time code appears in the changed files.
Container-Privileges	✅ Passed	PR only changes Go e2e test framework timeouts; no container/K8s manifests or privilege flags (privileged, hostNetwork, allowPrivilegeEscalation, etc.) were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only swaps framework init to use driver timeouts; no new log statements or sensitive data fields were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-98100, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-98100

This change is needed so that timeouts specified in openshift/ibm-vpc-block-csi-driver-operator#175 will take effect during e2e tests.

/cc @openshift/storage

Summary by CodeRabbit

• Tests
• Updated snapshot-related end-to-end tests to use storage-driver-specific timeout settings.
• Improved test reliability across drivers with varying operation durations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-cgroupsv2	de396e9	link	true	/test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-fips	de396e9	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-1of2	de396e9	link	true	/test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp	de396e9	link	true	/test e2e-gcp
ci/prow/e2e-aws-ovn-techpreview	de396e9	link	false	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-techpreview-serial-2of2	de396e9	link	false	/test e2e-aws-ovn-techpreview-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhrmo]

/lgtm

[dobsonj]

/assign @jubittajohn
for approval

[jubittajohn]

/lgtm
/approve

[jubittajohn]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jubittajohn, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [jubittajohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment