Skip to content

OCPBUGS-64841: post-process: Remove workaround for openvswitch additional group#1918

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
travier:master-remove-openvswitch-group-workaround
Apr 10, 2026
Merged

OCPBUGS-64841: post-process: Remove workaround for openvswitch additional group#1918
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
travier:master-remove-openvswitch-group-workaround

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Mar 26, 2026

We are moving the group inclusion directly to the RHEL base image instead of working around it here in the OCP node layer.

See: #1917
See: coreos/rhel-coreos-config#224
See: https://redhat.atlassian.net/browse/OCPBUGS-64841

We are moving the group inclusion directly to the RHEL base image
instead of working around it here in the OCP node layer.

See: openshift#1917
See: coreos/rhel-coreos-config#224
See: https://redhat.atlassian.net/browse/OCPBUGS-64841
@openshift-ci openshift-ci bot requested review from PeaceRebel and prestist March 26, 2026 11:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
@travier travier requested review from dustymabe and jlebon and removed request for PeaceRebel and prestist March 26, 2026 11:46
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 27, 2026

/retest

Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM but I guess it needs to wait until the RHCOS PR lands in the latest build

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 10, 2026

I've verified that the changes from coreos/rhel-coreos-config#224 landed in 9.8.20260409-dev0:

[core@cosa-devsh ~]$ grep containers /usr/lib/passwd /usr/lib/group 
/usr/lib/passwd:containers:x:790:790:User for rootless containers:/nonexistent:/sbin/nologin
/usr/lib/group:containers:x:790:

[core@cosa-devsh ~]$ getent passwd containers 
containers:x:790:790:User for rootless containers:/nonexistent:/sbin/nologin
[core@cosa-devsh ~]$ getent group containers 
containers:x:790:

[core@cosa-devsh ~]$ getent group hugetlbfs 
hugetlbfs:x:801:openvswitch

So we can merge this one now.

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 10, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@travier: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier travier changed the title post-process: Remove workaround for openvswitch additional group OCPBUGS-64841: post-process: Remove workaround for openvswitch additional group Apr 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 10, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@travier: This pull request references Jira Issue OCPBUGS-64841, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We are moving the group inclusion directly to the RHEL base image instead of working around it here in the OCP node layer.

See: #1917
See: coreos/rhel-coreos-config#224
See: https://redhat.atlassian.net/browse/OCPBUGS-64841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@joelcapitao joelcapitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, joelcapitao, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jlebon,joelcapitao,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 10, 2026

/verified by @travier

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 10, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@travier: This PR has been marked as verified by @travier.

Details

In response to this:

/verified by @travier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d9c290c into openshift:master Apr 10, 2026
3 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@travier: Jira Issue OCPBUGS-64841: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-64841 has been moved to the MODIFIED state.

Details

In response to this:

We are moving the group inclusion directly to the RHEL base image instead of working around it here in the OCP node layer.

See: #1917
See: coreos/rhel-coreos-config#224
See: https://redhat.atlassian.net/browse/OCPBUGS-64841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier travier deleted the master-remove-openvswitch-group-workaround branch April 10, 2026 13:43
@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 10, 2026

/cherrypick release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown

@travier: new pull request created: #1926

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 10, 2026

/cherrypick release-4.20
/cherrypick release-4.19

@openshift-cherrypick-robot
Copy link
Copy Markdown

@travier: new pull request created: #1927

Details

In response to this:

/cherrypick release-4.20
/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@travier: new pull request created: #1928

Details

In response to this:

/cherrypick release-4.20
/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-04-11-163821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants