Skip to content

fix(health): handle errors that cannot convert to strings - #10

Merged
thibaultleouay merged 3 commits into
openstatusHQ:mainfrom
ephraimduncan:fix/handle-unprintable-probe-errors
Sep 15, 2026
Merged

thibaultleouay merged 3 commits into
openstatusHQ:mainfrom
ephraimduncan:fix/handle-unprintable-probe-errors

Conversation

@ephraimduncan

Copy link
Copy Markdown
Contributor

Health endpoints return a report instead of rejecting when a probe throws a value that cannot convert to a string. Critical probes still report an unhealthy status, without private fields from the rejected value.

The same conversion error no longer interrupts the extend and exposeChecks fallbacks. Extension failures leave the report intact, and exposure failures keep details hidden. Existing Error objects, successful string conversions, and custom formatter failure behavior stay unchanged.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/health/src/errors.ts Outdated
thibaultleouay and others added 2 commits September 15, 2026 11:22
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@thibaultleouay
thibaultleouay merged commit 3ba9815 into openstatusHQ:main Sep 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants