Refactor button styles#2878
Open
TomWoodward wants to merge 4 commits into
Open
Conversation
TomWoodward
commented
May 29, 2026
RoyEJohnson
requested changes
Jun 1, 2026
Contributor
RoyEJohnson
left a comment
RoyEJohnson
left a comment
There was a problem hiding this comment.
There are two places where I noticed design changes.
| .put-away { | ||
| @include body-font(3.6rem); | ||
| @include button-reset(); | ||
|
|
Contributor
There was a problem hiding this comment.
The next two lines can be removed, as they're redundant with button-reset now, right?
|
|
||
| button { | ||
| @include button-reset(); | ||
|
|
Contributor
There was a problem hiding this comment.
again the next two lines could be removed
| // CTA buttons are large and uppercased. | ||
| .btn { | ||
| padding: 1.5rem 2rem; | ||
| text-transform: uppercase; |
Contributor
There was a problem hiding this comment.
The "Let us know" button was previously not uppercase. Is this a design change or the Assignable page?
| padding: 0.5rem 0 0.5rem 1rem; | ||
| } | ||
|
|
||
| button { |
Contributor
There was a problem hiding this comment.
These (/ally-logos, the copy buttons) lost padding and foreground/background color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes global
.btn,buttonstyles and re-applies them locally where necessary, also keeps them in any raw cms content.pushes common focus indicator styling down to the pattern-library, and bumps the underlying flex-page-renderer pattern library so everything is all consistent
the global
.btn,buttonstyles were not actually the same as the button macro ones, i preferred the pattern-library styles and removed the divergent ones so everything is alignedpattern library pr is openstax/pattern-library#77, this is included here already