Introduce build workflow with pixi.#34
Conversation
|
@hameerabbasi I am holding this for now pending a discussion about the future of our tooling in here. My thoughts:
|
|
This ideally requires pytorch/benchmark#2622 to be merged first. One caveat here is that One solution is to have a separate |
Done! It now supports all the YAML files in the original repo.
I would too, the only caveat being in #34 (comment). |
| echo "source $SCRIPT_DIR/torch-common.sh" > $CONDA_PREFIX/etc/conda/activate.d/activate-torch.sh | ||
| echo "source $SCRIPT_DIR/deactivate-torch-common.sh" > $CONDA_PREFIX/etc/conda/activate.d/deactivate-torch.sh |
There was a problem hiding this comment.
This is needed to make sure the environment is set up properly
There was a problem hiding this comment.
With conda, yes. But if you look at the following lines; pixi will take care of that for us. I'm calling the script inside the activation.scripts section of pixi.toml. https://github.com/Quansight/torch-build/blob/9634e209f33013e59901ded16db53c7957e9a68a/pixi.toml#L18-L19
There was a problem hiding this comment.
Pixi tasks are generally run under a new shell process with pixi shell or pixi run instead of in the same process. Thus the deactivation cleanup isn't needed. One CAN use the same shell with eval "$(pixi shell-hook)", but that's a fringe use-case.
No description provided.