Skip to content

[openwrt] remove the in-tree LuCI app (proposed for openwrt/luci) - #3326

Merged
jwhui merged 1 commit into
openthread:mainfrom
LorbusChris:luci-ucode
Aug 13, 2026
Merged

[openwrt] remove the in-tree LuCI app (proposed for openwrt/luci)#3326
jwhui merged 1 commit into
openthread:mainfrom
LorbusChris:luci-ucode

Conversation

@LorbusChris

@LorbusChris LorbusChris commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the in-tree OpenWrt LuCI app from ot-br-posix, so the web interface can be
maintained in the openwrt/luci repository instead (luci-app-openthread),
following the standard convention for LuCI apps, as requested by the OpenWrt
maintainers (#3431, openwrt/packages#29791).

Deletes the legacy Lua controller, the admin_thread .htm templates and
handle_error.js, stops installing them from the OpenWrt package, and drops the
now-unused luci-lua-runtime dependency.

Context

This PR previously rewrote the in-tree app to client-side JS + ucode. The OpenWrt
maintainers asked to move the app to openwrt/luci instead (#3431) rather than keep
it here, so this PR now just removes it. The proposed replacement app and the feed
change are open in parallel:

These are all still proposals under review; this removal should land in coordination
with them so users aren't left without the app.

An earlier revision of this PR also normalized the otbr ubus reply field names to
snake_case. That was dropped: it was incomplete/error-prone (the rename collided
with method names in the ubus dispatch table, e.g. leaderdata/joinernum), and
the openwrt/luci app simply reads the daemon's existing field names instead, which
removes the cross-repo ordering dependency entirely.

Refs: #3431, openwrt/packages#29791, openwrt/luci#8871

@LorbusChris

Copy link
Copy Markdown
Contributor Author

cc @stintel

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the OpenThread Border Router LuCI application from the legacy Lua-based framework to the modern LuCI client-side JavaScript framework and ucode backend. The changes involve replacing Lua controllers and templates with JS views and an RPCD ucode script. Review feedback highlights a logic error in the signal icon mapping and suggests strengthening input validation for the network key and PSKc fields by enforcing hexadecimal character checks.

@LorbusChris
LorbusChris marked this pull request as draft May 9, 2026 00:31
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.87%. Comparing base (2b41187) to head (4b19ef3).
⚠️ Report is 1597 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3326       +/-   ##
===========================================
- Coverage   55.77%   36.87%   -18.90%     
===========================================
  Files          87      144       +57     
  Lines        6890    17507    +10617     
  Branches        0     1431     +1431     
===========================================
+ Hits         3843     6456     +2613     
- Misses       3047    10683     +7636     
- Partials        0      368      +368     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LorbusChris
LorbusChris force-pushed the luci-ucode branch 3 times, most recently from 304ce06 to 12fc9ac Compare July 24, 2026 08:00
@LorbusChris
LorbusChris marked this pull request as ready for review July 24, 2026 13:59
@LorbusChris LorbusChris changed the title [openwrt] migrate LuCI WebUI from Lua to ucode + client-side JS [openwrt] normalize otbr ubus reply fields; remove in-tree LuCI app (moved to openwrt/luci) Jul 25, 2026
@LorbusChris LorbusChris changed the title [openwrt] normalize otbr ubus reply fields; remove in-tree LuCI app (moved to openwrt/luci) [openwrt] remove the in-tree LuCI app (migrated to openwrt/luci) Jul 25, 2026
@LorbusChris
LorbusChris marked this pull request as draft July 25, 2026 20:29
@LorbusChris LorbusChris changed the title [openwrt] remove the in-tree LuCI app (migrated to openwrt/luci) [openwrt] remove the in-tree LuCI app (proposed for openwrt/luci) Jul 25, 2026
@LorbusChris
LorbusChris marked this pull request as ready for review August 2, 2026 19:04
Comment thread etc/openwrt/openthread-br/Makefile Outdated
Comment thread etc/openwrt/openthread-br/Makefile
@LorbusChris
LorbusChris force-pushed the luci-ucode branch 2 times, most recently from 1143ebd to 8913fc6 Compare August 13, 2026 16:19
Comment thread etc/openwrt/openthread-br/README.md Outdated
The OpenWrt LuCI web interface for OTBR is now maintained in the
openwrt/luci repository as luci-app-openthread, per the OpenWrt
maintainers' request (openthread#3431,
openwrt/packages#29791). It has been rewritten there for the modern
client-side JS + rpcd ucode framework.

Remove the legacy Lua controller, the admin_thread .htm templates and
handle_error.js from this tree, stop installing them from the OpenWrt
package, and drop the now-unused luci-lua-runtime dependency.

@jwhui jwhui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui
jwhui merged commit c40529f into openthread:main Aug 13, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants