Skip to content

fix: avoid ts warning - #4313

Merged
zzcr merged 1 commit into
devfrom
shen/fix-build-bug
Sep 7, 2026
Merged

fix: avoid ts warning#4313
zzcr merged 1 commit into
devfrom
shen/fix-build-bug

Conversation

@shenjunjian

@shenjunjian shenjunjian commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

PR

声明写错了, 修改后能避免控制台打印告警

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the public type definition for Popper update data.
    • Improved type accuracy for integrations without changing runtime behavior.

@github-actions github-actions Bot added the bug Something isn't working label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1967b793-1289-43d4-b26d-77daa8d0c447

📥 Commits

Reviewing files that changed from the base of the PR and between e31f607 and f50bcd7.

📒 Files selected for processing (1)
  • packages/utils/src/popper/index.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


Walkthrough

The UpdateData.instance property now uses the exported PopperJS type instead of Popper. This change affects type declarations only and does not change runtime behavior.

Changes

Popper type correction

Layer / File(s) Summary
UpdateData instance type
packages/utils/src/popper/index.ts
The UpdateData.instance property now references PopperJS, matching the exported class name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f50bc

This change corrects the declared Popper instance type to match the class used at runtime, preventing the TypeScript warning without changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the types with care
PopperJS now waits there
No runtime hops, no hidden track
Just one clear name in the stack
The contract shines, precise and bright

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the TypeScript warning fix, which matches the primary change from Popper to PopperJS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shen/fix-build-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zzcr
zzcr merged commit 2167334 into dev Sep 7, 2026
11 checks passed
@zzcr
zzcr deleted the shen/fix-build-bug branch September 7, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants