fix(upload-list): When maxNameLength is not set, excessively long file names are displayed using CSS ellipsis. - #4315
fix(upload-list): When maxNameLength is not set, excessively long file names are displayed using CSS ellipsis.#4315discreted66 wants to merge 1 commit into
Conversation
- maxNameLength 默认值从 20 改为 0,未设置时不进行 JS 截断 - 为 __item-name 添加 CSS text-overflow:ellipsis 实现超长省略 - 为 SAAS 主题 __li-title 补充缺失的省略号样式及宽度约束 - --picture 模式下设置 overflow:visible 以保持浮动缩略图布局
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughUpload lists now display full filenames by default. Truncation runs only when ChangesUpload filename display
Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to The PR changes long filename handling from JavaScript truncation to CSS ellipsis when maxNameLength is unset, while preserving explicit positive limits. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/vue/src/file-upload/src/index.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/vue/src/upload-list/src/index.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency). packages/vue/src/upload-list/src/mobile-first.vueESLint skipped: the matched ESLint configuration already failed (missing-dependency).
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fix(upload-list): 未设置 maxNameLength 时超长文件名通过 CSS 省略号显示
maxNameLength 默认值从 20 改为 0,未设置时不进行 JS 截断
为 __item-name 添加 CSS text-overflow:ellipsis 实现超长省略
为 SAAS 主题 __li-title 补充缺失的省略号样式及宽度约束
--picture 模式下设置 overflow:visible 以保持浮动缩略图布局
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit