[focusgroup] Rename focusgroup-entry-priority to focusgroupstart#1356
Merged
lukewarlow merged 4 commits intoopenui:mainfrom Jan 29, 2026
Merged
[focusgroup] Rename focusgroup-entry-priority to focusgroupstart#1356lukewarlow merged 4 commits intoopenui:mainfrom
lukewarlow merged 4 commits intoopenui:mainfrom
Conversation
janewman
requested review from
dbaron,
gregwhitworth,
mfreed7 and
travisleithead
as code owners
Collaborator
|
I think focusgroupentry or focusgroupstart are fine. I think it should specifically say focusgroup not just focus. I think changing to focusgroupstart and can kicking the bikeshedding is fine. |
janewman
changed the title
lukewarlow
approved these changes
Jan 16, 2026
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 20, 2026
…bindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 4021071 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef
ajperel
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 20, 2026
…bindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 40210717 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486357 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1571940}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 21, 2026
…bindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 4021071 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486357 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1571940}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 21, 2026
…bindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 4021071 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486357 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1571940}
KurtCattiSchmidt
pushed a commit
to KurtCattiSchmidt/wpt-ahem
that referenced
this pull request
Jan 21, 2026
…bindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 4021071 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486357 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1571940}
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jan 23, 2026
…from items with a negative tabindex., a=testonly Automatic update from web-platform-tests [focusgroup] Allow directional movement from items with a negative tabindex. This ensures that when focus is placed on an element within a focusgroup with tabindex="-1", a user can use directional focus navigation (arrow keys) to move focus FROM that element TO another focusgroup item. Like when using tab navigation, there is no ability to use the keyboard to move focus TO an element with tabindex="-1" See issue on OpenUI: openui/open-ui#1358 Explainer update PR: openui/open-ui#1356 Bug: 40210717 Change-Id: I31966312b26e0337efbc440d2bad06399c7f29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486357 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1571940} -- wpt-commits: 8ffa4295d6624f40cb851d86a126223407ebd556 wpt-pr: 57266
Collaborator
Author
|
@gregwhitworth, or @mfreed7 PTAL for owner review, thanks! |
Collaborator
Author
|
@mfreed7 (or anyone else with permission) can you hit the merge button for me? @gregwhitworth can you add me here so I can hit the merge button, add labels, etc? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
focusgroup-entry-prioritytofocusgroupstart([focusgroup] Should a new attribute be used to manage entry priority rather than tabindex? #1314)tabindex="-1"can now participate in focusgroup navigation when focused ([focusgroup] Should elements withtabindex="-1"participate in focusgroup navigation when focused? #1358)