Skip to content

Support alt, toneshift in BaseKoreanPhonemizer #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EX3exp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support alt, toneshift in BaseKoreanPhonemizer #2248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions OpenUtau.Plugin.Builtin/BaseKoreanPhonemizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,12 @@ protected virtual bool additionalTest(string lyric) {
string phonemeToReturn;
var attr = note.phonemeAttributes?.FirstOrDefault(attr => attr.index == 0) ?? default;
string color = attr.voiceColor ?? string.Empty;
int toneShift = 0;
int? alt = null;
if (phoneme.Equals("")) {return phoneme;}

if (singer.TryGetMappedOto(phoneme + alt, note.tone + toneShift, color, out var otoAlt)) {
if (singer.TryGetMappedOto(phoneme + attr.alternate, note.tone + attr.toneShift, color, out var otoAlt)) {
phonemeToReturn = otoAlt.Alias;
}
else if (singer.TryGetMappedOto(phoneme, note.tone + toneShift, color, out var oto)) {
else if (singer.TryGetMappedOto(phoneme, note.tone + attr.toneShift, color, out var oto)) {
phonemeToReturn = oto.Alias;
}
else if (singer.TryGetMappedOto(phoneme, note.tone, color, out oto)) {
Expand Down
Loading