Skip to content

Skip DLLs referenced by legacy plugins #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maiko3tattun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip DLLs referenced by legacy plugins #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion OpenUtau.Core/DocManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void SearchAllPlugins() {
if (File.Exists(oldBuiltin)) {
File.Delete(oldBuiltin);
}
files.AddRange(Directory.EnumerateFiles(PathManager.Inst.PluginsPath, "*.dll", SearchOption.AllDirectories));
SearchPluginInternal(PathManager.Inst.PluginsPath, files);
} catch (Exception e) {
Log.Error(e, "Failed to search plugins.");
}
Expand Down Expand Up @@ -118,6 +118,16 @@ public void SearchAllPlugins() {
stopWatch.Stop();
Log.Information($"Search all plugins: {stopWatch.Elapsed}");
}
private void SearchPluginInternal(string path, List<string> result) {
if (Directory.EnumerateFiles(path, "plugin.txt", SearchOption.TopDirectoryOnly).Any()) {
return;
}
result.AddRange(Directory.EnumerateFiles(path, "*.dll", SearchOption.TopDirectoryOnly));
var directories = Directory.EnumerateDirectories(path, "*", SearchOption.TopDirectoryOnly);
foreach (var directory in directories) {
SearchPluginInternal(directory, result);
}
}

#region Command Queue

Expand Down
Loading