ci: test_entrypoint: drop the kmods feed before installing packages - #130
Draft
BKPepe wants to merge 1 commit into
Draft
ci: test_entrypoint: drop the kmods feed before installing packages#130BKPepe wants to merge 1 commit into
BKPepe wants to merge 1 commit into
Conversation
The kmods feed only exists for the exact kernel the rootfs image was built with. Once the branch moves to a newer kernel, the old kmods directory is removed from the download server and opkg update inside the container fails with a 404, taking down every runtime test even though the tested package built fine. The tests install the built packages from the local packages_ci feed and do not need the kmods feed, so drop it from the feed configuration instead of failing on it. The apk-based branches generate the same kmods entry in distfeeds.list (see include/feeds.mk in openwrt.git), so treat both package managers the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime-test containers are built from the
openwrt/rootfs:<arch>-<branch>images, which carry the kmods feed URL for the exact kernel they were built with. When the branch moves to a newer kernel, the old kmods directory is removed from the download server andopkg updateinside the container fails with a 404, so every runtime test fails even though the tested package built fine. This is currently the case for all-openwrt-24.10images (see e.g. openwrt/packages#30260, where the package compiles on all architectures but the runtime tests fail with a 404 on the kmods feed).The tests install the built packages from the local
packages_cifeed and do not need the kmods feed, so drop it from the feed configuration before updating. The apk-based branches generate the same kmods entry indistfeeds.list(include/feeds.mkin openwrt.git), so both package managers get the same treatment.This complements openwrt/docker#208, which keeps the images fresh — this change keeps the tests working when they are not.