CI: switch to common formalities workflow - #8066
Merged
systemcrash merged 1 commit intoNov 7, 2025
Merged
Conversation
GeorgeSapkin
force-pushed
the
ci-switch-to-common-formalities
branch
from
November 6, 2025 13:15
81d1053 to
d3db74c
Compare
Contributor
|
NACK - this breaks workflows and custom checks necessary in this repo. |
Member
Author
|
Can you be more specific? |
Contributor
Member
Author
|
These changes are integrated in the PR from the description (the one you commented in). It's not merged yet hence the failing check. Did I miss something specific? |
systemcrash
marked this pull request as draft
November 6, 2025 16:11
Contributor
|
No - it pointed to main which was why I didn't find your amendments. |
Member
|
on notice: @Ansuel |
BKPepe
approved these changes
Nov 7, 2025
Switch to using the common formalities workflow defined in the actions-shared-workflows that include luci-specific exceptions. Fixes: openwrt#7821 Signed-off-by: George Sapkin <george@sapk.in>
GeorgeSapkin
force-pushed
the
ci-switch-to-common-formalities
branch
from
November 7, 2025 11:38
d3db74c to
3ce1313
Compare
GeorgeSapkin
marked this pull request as ready for review
November 7, 2025 11:49
Member
Author
|
Parent PR merged and local formalities pass 🎉 |
Contributor
|
Merged. Thanks @GeorgeSapkin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using the common formalities workflow defined in the actions-shared-workflows that include luci-specific exceptions.
Depends on openwrt/actions-shared-workflows#61 (old formalities check does not pass this PR due to a missing script).
Fixes: #7821
CC: @aparcar, @systemcrash
TODO: