Skip to content

luci-app-watchcat: add support for 'enabled' option #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ser9ei wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −32
Open

luci-app-watchcat: add support for 'enabled' option #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ return view.extend({

s.tab('general', _('General Settings'));

o = s.taboption('general', form.Flag, 'enabled',
_('Enabled'),
_('Enable or disable this Watchcat instance'));
o.default = '1';

@openwrt-ai openwrt-ai Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

option enabled only lands in /etc/config/watchcat once the user saves this page — AbstractValue.parse() writes it because rmempty = false, but pre-existing sections that are never re-saved keep no enabled line at all. Current master of the backend never reads the option (config_watchcat() in watchcat.init has no config_get_bool enabled), and the shipped watchcat.config default section has none either.

Does openwrt/packages#30234 use config_get_bool enabled "$1" enabled "1" (i.e. absent == enabled)? If it defaults to 0, every existing installation's watchcat instances would silently stop after the package upgrade. I can't read that PR from this session, so flagging it as a question rather than an assertion.

Generated by Claude Code

o.rmempty = false;

o = s.taboption('general', form.ListValue, 'mode',
_('Mode'),
_("Ping Reboot: Reboot this device if a ping to a specified host fails for a specified duration of time. <br /> \
Expand Down
72 changes: 40 additions & 32 deletions applications/luci-app-watchcat/po/templates/watchcat.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
msgid ""
msgstr "Content-Type: text/plain; charset=UTF-8"

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:94
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:100
msgid ""
"<i>Applies to Ping Reboot and Periodic Reboot modes</i> <br /> When "
"rebooting the router, the service will trigger a soft reboot. Entering a non-"
Expand All @@ -10,36 +10,44 @@ msgid ""
"use 0 to disable the forced reboot delay."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:111
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:117
msgid ""
"<i>Applies to Ping Reboot and Restart Interface modes</i> <br /> If using "
"ModemManager, you can have Watchcat restart your ModemManager interface by "
"specifying its name."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:104
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:110
msgid ""
"<i>Applies to Ping Reboot, Restart Interface, and Run Script modes</i> <br /"
"> Specify the interface to monitor and react if a ping over it fails."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:60
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:66
msgid "Address family for pinging the host"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:65
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:71
msgid "Any"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:84
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:90
msgid "Big: 248 bytes"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:70
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:76
msgid "Check Interval"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:93
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:23
msgid "Enable or disable this Watchcat instance"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:22
msgid "Enabled"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:99
msgid "Force Reboot Delay"
msgstr ""

Expand All @@ -58,11 +66,11 @@ msgid ""
"up more than one action."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:52
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:58
msgid "Hosts To Check"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:71
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:77
msgid ""
"How often to ping the host specified above. <br /><br />The default unit is "
"seconds, without a suffix, but you can use the suffix <b>m</b> for minutes, "
Expand All @@ -72,21 +80,21 @@ msgid ""
"li><ul>"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:85
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:91
msgid "Huge: 1492 bytes"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:52
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:58
msgid "IP addresses or hostnames to ping."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:118
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:124
msgid ""
"If using ModemManager, then before restarting the interface, set the modem "
"to be allowed to use any band."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:41
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:47
msgid ""
"In Periodic Reboot mode, it defines how often to reboot. <br /> In Ping "
"Reboot mode, it defines the longest period of time without a reply from the "
Expand All @@ -100,43 +108,43 @@ msgid ""
"li><li>1 week would be: <b>7d</b></li><ul>"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:102
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:108
msgid "Interface"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:103
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:109
msgid "Interface to monitor and/or restart"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:86
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:92
msgid "Jumbo: 9000 bytes"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:22
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:28
msgid "Mode"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:110
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:116
msgid "Name of ModemManager Interface"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:40
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:46
msgid "Period"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:28
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:34
msgid "Periodic Reboot"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:80
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:86
msgid "Ping Packet Size"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:27
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:33
msgid "Ping Reboot"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:23
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:29
msgid ""
"Ping Reboot: Reboot this device if a ping to a specified host fails for a "
"specified duration of time. <br /> Periodic Reboot: Reboot this device after "
Expand All @@ -146,37 +154,37 @@ msgid ""
"for a specified duration of time. <br />"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:29
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:35
msgid "Restart Interface"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:30
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:36
msgid "Run Script"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:33
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:39
msgid "Script to run"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:34
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:40
msgid ""
"Script to run when the host has not responded for the specified duration of "
"time. The script is passed the interface name as $1"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:81
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:87
msgid "Small: 1 byte"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:83
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:89
msgid "Standard: 56 bytes"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:15
msgid "These rules will govern how this device reacts to network events."
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:117
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:123
msgid "Unlock Modem Bands"
msgstr ""

Expand All @@ -186,6 +194,6 @@ msgstr ""
msgid "Watchcat"
msgstr ""

#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:82
#: applications/luci-app-watchcat/htdocs/luci-static/resources/view/watchcat.js:88
msgid "Windows: 32 bytes"
msgstr ""