Skip to content

luci-base: form.js: fix stripTags NotFoundError and modify source node #8936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjm2473 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

luci-base: form.js: fix stripTags NotFoundError and modify source node #8936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19a5954
luci-base: form.js: fix stripTags NotFoundError
jjm2473 Aug 12, 2026
619ce76
luci-base: form.js: fix stripTags modify source node
jjm2473 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/luci-base/htdocs/luci-static/resources/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,10 @@
if (typeof(s) == 'string' && !s.match(/[<>&]/))
return s;

const x = dom.elem(s) ? s : dom.parse(`<div>${s}</div>`);
const x = dom.elem(s) ? s.cloneNode(true) : dom.parse(`<div>${s}</div>`);

x.querySelectorAll('br').forEach((br) => {
x.replaceChild(document.createTextNode('\n'), br);
br.parentNode.replaceChild(document.createTextNode('\n'), br);
Comment thread
jjm2473 marked this conversation as resolved.
});

return (x.textContent ?? x.innerText ?? '').replace(/([ \t]*\n)+/g, '\n');
Expand Down Expand Up @@ -2757,7 +2757,7 @@
},


/**

Check warning on line 2760 in modules/luci-base/htdocs/luci-static/resources/form.js

View workflow job for this annotation

GitHub Actions / eslint 

Missing JSDoc @PARAM "ev" declaration
* Clone the section_id, putting the clone immediately after if put_next
* is true. Optionally supply a name for the new section_id.
*
Expand Down