luci-proto-modemmanager: fix iptype default value - #8944
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The 'iptype' and 'init_iptype' ListValue options declared 'ipv4v6' as
the default in LuCI, while the modemmanager package itself defaults to
'ipv4' (see net/modemmanager README.md).
Since LuCI omits writing a UCI option when the selected value matches
the field's declared default, selecting 'IPv4/IPv6 (both)' in the UI
never actually saved 'option iptype ipv4v6' to /etc/config/network.
On the next apply, modemmanager fell back to its own default ('ipv4'),
silently downgrading the connection to IPv4-only and making the
'ipv4v6' option effectively unusable through LuCI.
Align both defaults with the modemmanager package default ('ipv4') and
drop the now-inaccurate '- defaults to IPv4' hint from the 'ipv4v6'
label. The dropdown entries are also reordered so the new default
('ipv4') is listed first, matching the convention used by other
ListValue fields in this file.
Reported-by: moawut <https://forum.openwrt.org/u/moawut>
Ref: https://forum.openwrt.org/t/luci-proto-modemmanager-support-thread/23696/120
Signed-off-by: Michael Pfeifroth <micpf@westermo.com>
micpf
force-pushed
the
fix-modemmanager-iptype-default
branch
from
August 17, 2026 13:11
8352451 to
e09f743
Compare
Contributor
Author
|
Both nits addressed:
Force-pushed the updated commit. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
Thanks merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
iptypeandinit_iptypeListValueoptions inmodemmanager.jsdeclaredipv4v6as the default, while themodemmanagerpackage itself defaults toipv4(see net/modemmanager README.md).Since LuCI's form widgets skip writing a UCI option to
/etc/config/networkwhen the selected value equals the field's declared default, selecting IPv4/IPv6 (both) in the UI never actually persistedoption iptype 'ipv4v6'. On save/apply, modemmanager then fell back to its own default (ipv4), silently downgrading the connection to IPv4-only — making theipv4v6option effectively impossible to use through LuCI.This PR aligns both
iptypeandinit_iptypedefaults with the modemmanager package default (ipv4), and drops the now-inaccurate- defaults to IPv4hint from theipv4v6label.Issue reported by
Originally reported and diagnosed by @moawut on the forum:
https://forum.openwrt.org/t/luci-proto-modemmanager-support-thread/23696/120