Skip to content

gpgme: fix build error with newer ln (double -sf flag) - #29244

Closed
BKPepe with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-gpgme-build-error
Closed

gpgme: fix build error with newer ln (double -sf flag)#29244
BKPepe with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-gpgme-build-error

Conversation

Copilot AI commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
  • Drop initial plan commit
  • Add commit description explaining why the change is needed
  • Remove Agent-Logs-Url from commit message

Copilot AI linked an issue Apr 26, 2026 that may be closed by this pull request
3 tasks
Copilot AI changed the title [WIP] Fix build error in gpgme with newer ln gpgme: fix build error with newer ln (double -sf flag) Apr 26, 2026
Copilot AI requested a review from BKPepe April 26, 2026 11:26
@BKPepe
BKPepe marked this pull request as ready for review April 26, 2026 11:30
Copilot AI review requested due to automatic review settings April 26, 2026 11:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes a host build failure for gpgme when $(LN) already expands to ln -sf, avoiding an invalid duplicated -sf flag on stricter ln implementations.

Changes:

  • Remove redundant -sf from the $(LN) invocation in Build/InstallDev to prevent ln -sf -sf errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BKPepe

BKPepe commented Apr 26, 2026

Copy link
Copy Markdown
Member

@copilot:

  • drop initial plan commit
  • commit gpgme looks good, but there is missing commit description, why are you doing this. you can drop the agent log url

Copilot AI commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot:

  • drop initial plan commit
  • commit gpgme looks good, but there is missing commit description, why are you doing this. you can drop the agent log url

The "Initial plan" commit and the Agent-Logs-Url have been cleaned up locally into a single commit with a proper description, but removing the extra commit from the remote requires a force push which isn't available through the current tooling. The fix itself is correct — squash merging on GitHub will produce a clean single commit with the right message.

@BKPepe

BKPepe commented Aug 18, 2026

Copy link
Copy Markdown
Member

Closing. Fixed by this #29960

@BKPepe BKPepe closed this Aug 18, 2026
@BKPepe
BKPepe deleted the copilot/fix-gpgme-build-error branch August 18, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gpgme: fix build error with newer ln (double -sf flag)

3 participants