Skip to content

ci: trigger Build and Test once FormalityCheck passed #29860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BKPepe merged 1 commit into from
Jun 30, 2026
Merged

ci: trigger Build and Test once FormalityCheck passed #29860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/multi-arch-test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
name: Test and Build

on:
check_suite:
types: [completed]
pull_request:

Comment on lines 3 to 5

@BKPepe BKPepe Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done in the actions-shared-workflows:
https://github.com/openwrt/actions-shared-workflows/blob/4a5f62094fdce61592d4e94e211cb2a7566e23ef/.github/workflows/multi-arch-test-build.yml#L18

permissions:
contents: read
pull-requests: write
checks: read

jobs:
wait-for-formalities:
name: Wait for FormalityCheck
runs-on: ubuntu-slim
steps:
Comment on lines +12 to +15

@BKPepe BKPepe Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to add timeout-minutes: 30 here:

- name: Wait for Check Run
uses: lewagon/wait-on-check-action@v1.8.0
with:
ref: ${{ github.event.pull_request.head.sha }}
check-name: 'FormalityCheck / Git & Commits'

@GeorgeSapkin GeorgeSapkin Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is FormalityCheck / Git & Commits coming from?

@BKPepe BKPepe Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new thing that I introduced in cooperation with @Ansuel. It will be publicly available to see in this repo https://github.com/openwrt/openwrt-bot-worker shortly. It's an integrated webhook that gives you almost instant feedback. I originally wanted to write it as a PHP script, but it's done in JavaScript.

Compared to using a GitHub runner, it's incredibly fast because it doesn't have to wait for a runner to boot up or for available runner capacity. Right after creating a pull request, the user gets feedback based on three checks, which I'd like to expand in the future. Essentially, it does the same thing as your HyperStickler, but it's much more powerful and modular.

What you're looking for is right here:
https://github.com/openwrt/openwrt-bot-worker/blob/96551fca7cda708512c1af0459d46b152d00c223/cloudflare-worker/src/index.js#L304

repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 5

build:
name: Feeds Package Test Build
if: ${{ github.event.check_suite.conclusion == 'success' }}
needs: wait-for-formalities
uses: openwrt/actions-shared-workflows/.github/workflows/multi-arch-test-build.yml@main
Loading